Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: rename genesis.json used in tests to genesis-example.json #322

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

hadjiszs
Copy link
Member

@hadjiszs hadjiszs commented Oct 3, 2023

Description

Simply renaming the genesis.json file used in the tests to genesis-example.json to avoid confusions

@hadjiszs hadjiszs requested a review from a team as a code owner October 3, 2023 18:45
@hadjiszs hadjiszs requested review from dvdplm and atanmarko October 3, 2023 18:45
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (705b97e) 60.52% compared to head (66ecaa1) 60.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   60.52%   60.51%   -0.02%     
==========================================
  Files         225      225              
  Lines       12049    12049              
==========================================
- Hits         7293     7291       -2     
- Misses       4756     4758       +2     
Files Coverage Δ
crates/topos/src/config/genesis/tests.rs 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also clear out the file of things like e.g. the bootnodes that can't be used anyway?

@hadjiszs
Copy link
Member Author

hadjiszs commented Oct 4, 2023

Can we also clear out the file of things like e.g. the bootnodes that can't be used anyway?

ah they do actually, the tests are also covering the parsing of this section

@dvdplm
Copy link
Contributor

dvdplm commented Oct 6, 2023

ah they do actually, the tests are also covering the parsing of this sect

Can we have a copy just for the tests then? genesis-tests.json?

@dvdplm dvdplm merged commit 3b16003 into main Oct 6, 2023
@dvdplm dvdplm deleted the rename-genesis-example branch October 6, 2023 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants