This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
feat(api/grpc): add synchronization proto #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freyskeyd
requested review from
gruberb and
hadjiszs
and removed request for
a team
Freyskeyd
force-pushed
the
feature/create-grpc-behaviour
branch
from
496fcbd to
5534046
Compare
Freyskeyd
force-pushed
the
feature/create-synchronization-protocol
branch
2 times, most recently
from
d2d7615 to
f37e7e1
Compare
Freyskeyd
force-pushed
the
feature/create-grpc-behaviour
branch
from
5534046 to
88953eb
Compare
Freyskeyd
force-pushed
the
feature/create-synchronization-protocol
branch
from
f37e7e1 to
d71a995
Compare
Freyskeyd
force-pushed
the
feature/create-grpc-behaviour
branch
from
88953eb to
7ddfd88
Compare
Freyskeyd
force-pushed
the
feature/create-synchronization-protocol
branch
from
d71a995 to
d96ddd4
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 60.77% 60.73% -0.05%
==========================================
Files 235 231 -4
Lines 12934 12085 -849
==========================================
- Hits 7861 7340 -521
+ Misses 5073 4745 -328
☔ View full report in Codecov by Sentry. |
Freyskeyd
force-pushed
the
feature/create-grpc-behaviour
branch
4 times, most recently
from
5798914 to
db66cf4
Compare
Freyskeyd
force-pushed
the
feature/create-synchronization-protocol
branch
from
d96ddd4 to
6116b37
Compare
Freyskeyd
force-pushed
the
feature/create-grpc-behaviour
branch
2 times, most recently
from
f6f1936 to
2311ede
Compare
Freyskeyd
force-pushed
the
feature/create-synchronization-protocol
branch
4 times, most recently
from
32cab65 to
93a4b64
Compare
Freyskeyd
force-pushed
the
feature/create-synchronization-protocol
branch
2 times, most recently
from
8e9941a to
896a217
Compare
This was referenced Oct 11, 2023
dvdplm
reviewed
Oct 13, 2023
dvdplm
reviewed
Oct 13, 2023
dvdplm
reviewed
Oct 13, 2023
Freyskeyd
force-pushed
the
feature/create-synchronization-protocol
branch
from
896a217 to
8bfa1f1
Compare
Freyskeyd
force-pushed
the
feature/create-synchronization-protocol
branch
from
8bfa1f1 to
05a3192
Compare
Freyskeyd
force-pushed
the
feature/create-synchronization-protocol
branch
from
05a3192 to
43dae86
Compare
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Freyskeyd
force-pushed
the
feature/create-synchronization-protocol
branch
from
43dae86 to
3a1cc4d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous PR: #331
Next PR: #333
This PR adds the definition of the
gRPCsynchronization protocol, which contains various structs and also service definition.This protocol will evolve as we implement and update the different kind of synchronization.
PR Checklist: