Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

test: update path for github actions execution #336

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Freyskeyd
Copy link
Member

Description

Update the github actions to execute on push: master and pull_request events [opened, synchronize, reopened, ready_for_review]

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd requested a review from a team as a code owner October 10, 2023 13:56
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is opened, synchronize and reopened, so this adds ready_for_review to that. Would have been good to include that info in the PR description.

One question I have is if we should run workflows against main whenever a PR merges. Thoughts?

@Freyskeyd
Copy link
Member Author

@dvdplm I think they are running because a merge is a push on main

@Freyskeyd Freyskeyd merged commit 560c0ca into main Oct 10, 2023
@Freyskeyd Freyskeyd deleted the feature/update-github-actions-path branch October 10, 2023 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants