This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
+ Coverage 60.92% 61.60% +0.68%
==========================================
Files 233 219 -14
Lines 12282 12008 -274
==========================================
- Hits 7483 7398 -85
+ Misses 4799 4610 -189 ☔ View full report in Codecov by Sentry. |
JDawg287
force-pushed
the
feat/TP-715
branch
6 times, most recently
from
November 8, 2023 23:44
52e0851
to
4f1dd13
Compare
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
This reverts commit 05f929b. Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
This reverts commit 4925ec8. Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
dvdplm
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
JDawg287
force-pushed
the
feat/TP-715
branch
from
November 10, 2023 17:08
8b61825
to
a9ea306
Compare
Freyskeyd
reviewed
Nov 10, 2023
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
atanmarko
reviewed
Nov 14, 2023
atanmarko
reviewed
Nov 14, 2023
Signed-off-by: Bastian Gruber <foreach@me.com>
The docker-compose setup is failing again after the latest changes.
|
atanmarko
approved these changes
Nov 14, 2023
hadjiszs
approved these changes
Nov 14, 2023
crates/topos/src/components/regtest/commands/push_certificate.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up not used
CLI
flags. WIP, putting it up there early to discuss.Fixes TP-715
Breaking changes
docker
testing setup due to the usage oftce keys
.PR Checklist: