Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: cleanup cli commands #352

Merged
merged 40 commits into from
Nov 14, 2023
Merged

fix: cleanup cli commands #352

merged 40 commits into from
Nov 14, 2023

Conversation

gruberb
Copy link
Contributor

@gruberb gruberb commented Oct 26, 2023

Description

Cleaning up not used CLI flags. WIP, putting it up there early to discuss.

Fixes TP-715

Breaking changes

  • Will break the local docker testing setup due to the usage of tce keys.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 160 lines in your changes are missing coverage. Please review.

Comparison is base (4799cce) 60.92% compared to head (3853fc5) 61.60%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ates/topos/src/components/node/services/process.rs 20.00% 80 Missing ⚠️
crates/topos/src/components/node/mod.rs 12.50% 42 Missing ⚠️
crates/topos/src/components/regtest/mod.rs 0.00% 19 Missing ⚠️
crates/topos/src/config/mod.rs 62.50% 3 Missing ⚠️
crates/topos/src/config/node.rs 66.66% 3 Missing ⚠️
crates/topos/src/config/tce.rs 0.00% 3 Missing ⚠️
crates/topos/src/components/regtest/commands.rs 75.00% 2 Missing ⚠️
crates/topos/src/tracing.rs 0.00% 2 Missing ⚠️
crates/topos-wallet/src/lib.rs 0.00% 1 Missing ⚠️
crates/topos/src/components/node/commands.rs 66.66% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   60.92%   61.60%   +0.68%     
==========================================
  Files         233      219      -14     
  Lines       12282    12008     -274     
==========================================
- Hits         7483     7398      -85     
+ Misses       4799     4610     -189     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JDawg287 JDawg287 force-pushed the feat/TP-715 branch 6 times, most recently from 52e0851 to 4f1dd13 Compare November 8, 2023 23:44
@gruberb gruberb marked this pull request as ready for review November 9, 2023 13:55
@gruberb gruberb requested a review from a team as a code owner November 9, 2023 13:55
@gruberb gruberb requested review from hadjiszs and JDawg287 November 9, 2023 13:55
gruberb and others added 19 commits November 9, 2023 19:48
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
This reverts commit 05f929b.

Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
This reverts commit 4925ec8.

Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Signed-off-by: Jawad Tariq <sjcool420@hotmail.co.uk>
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/topos/tests/snapshots/node__help_display.snap Outdated Show resolved Hide resolved
crates/topos/src/tracing.rs Outdated Show resolved Hide resolved
crates/topos/src/config/mod.rs Outdated Show resolved Hide resolved
crates/topos/src/components/node/mod.rs Outdated Show resolved Hide resolved
crates/topos/src/components/node/mod.rs Outdated Show resolved Hide resolved
crates/topos/src/components/node/mod.rs Show resolved Hide resolved
crates/topos/src/components/node/services/process.rs Outdated Show resolved Hide resolved
crates/topos/src/components/node/services/process.rs Outdated Show resolved Hide resolved
crates/topos/src/components/node/services/process.rs Outdated Show resolved Hide resolved
.github/workflows/docker_utils.yml Show resolved Hide resolved
crates/topos/src/components/mod.rs Show resolved Hide resolved
crates/topos/src/components/node/mod.rs Outdated Show resolved Hide resolved
crates/topos/src/components/node/mod.rs Outdated Show resolved Hide resolved
crates/topos/src/components/node/mod.rs Show resolved Hide resolved
crates/topos/src/components/node/services/process.rs Outdated Show resolved Hide resolved
crates/topos/src/tracing.rs Outdated Show resolved Hide resolved
@JDawg287
Copy link
Member

The docker-compose setup is failing again after the latest changes.

$ docker logs boot
⚙️ Reading the configuration from /tmp/node_config/node/boot/config.toml
2023-11-14T19:09:40.166011Z  INFO topos::config::genesis: Reading subnet genesis file /tmp/node_config/subnet/topos/genesis.json
2023-11-14T19:09:40.180451Z  INFO topos::components::node: 🧢 New joiner: boot for the "topos" subnet as Validator
Error: SetGlobalDefaultError("a global default trace dispatcher has already been set")

crates/topos/src/components/regtest/commands.rs Outdated Show resolved Hide resolved
crates/topos/tests/config.rs Show resolved Hide resolved
@gruberb gruberb merged commit d951171 into main Nov 14, 2023
15 of 16 checks passed
@gruberb gruberb deleted the feat/TP-715 branch November 14, 2023 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants