Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: topos node init test #367

Merged
merged 4 commits into from
Nov 8, 2023
Merged

feat: topos node init test #367

merged 4 commits into from
Nov 8, 2023

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented Nov 8, 2023

Description

Test cli and env parameters for topos node init

Fixes TP-765

Additions and Changes

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Nov 8, 2023
@atanmarko atanmarko requested a review from a team as a code owner November 8, 2023 11:16
Marko Atanasievski added 2 commits November 8, 2023 12:18
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b345da7) 60.61% compared to head (b240a04) 60.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   60.61%   60.97%   +0.35%     
==========================================
  Files         233      233              
  Lines       12194    12273      +79     
==========================================
+ Hits         7391     7483      +92     
+ Misses       4803     4790      -13     
Files Coverage Δ
crates/topos/src/config/base.rs 59.45% <100.00%> (-8.11%) ⬇️
crates/topos/tests/config.rs 99.43% <100.00%> (+0.46%) ⬆️
crates/topos/src/components/node/services.rs 20.00% <0.00%> (ø)
crates/topos/src/components/node/mod.rs 37.65% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/topos/tests/config.rs Outdated Show resolved Hide resolved
crates/topos/tests/config.rs Show resolved Hide resolved
@atanmarko atanmarko requested review from gruberb and dvdplm November 8, 2023 13:48
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atanmarko atanmarko merged commit 4db1a63 into main Nov 8, 2023
@atanmarko atanmarko deleted the feat/TP-765 branch November 8, 2023 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants