Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

fix: subnet genesis file error #368

Merged
merged 5 commits into from
Nov 9, 2023
Merged

fix: subnet genesis file error #368

merged 5 commits into from
Nov 9, 2023

Conversation

atanmarko
Copy link
Member

Description

Update topos node up subnet error messages.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Sorry, something went wrong.

@atanmarko atanmarko self-assigned this Nov 8, 2023
@atanmarko atanmarko marked this pull request as ready for review November 8, 2023 13:30
@atanmarko atanmarko requested a review from a team as a code owner November 8, 2023 13:30
@atanmarko atanmarko requested review from dvdplm and JDawg287 November 8, 2023 13:30
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (4db1a63) 61.00% compared to head (80ad88c) 60.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   61.00%   60.92%   -0.08%     
==========================================
  Files         233      233              
  Lines       12273    12282       +9     
==========================================
- Hits         7487     7483       -4     
- Misses       4786     4799      +13     
Files Coverage Δ
crates/topos/src/config/genesis/tests.rs 100.00% <ø> (ø)
crates/topos/src/config/genesis/mod.rs 95.89% <80.00%> (ø)
crates/topos/src/components/node/mod.rs 35.67% <0.00%> (-1.99%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko atanmarko requested a review from gruberb November 8, 2023 13:51
crates/topos/src/components/node/mod.rs Outdated Show resolved Hide resolved
@atanmarko atanmarko force-pushed the fix/genesis_file_error branch from 69b479f to 8123e60 Compare November 8, 2023 14:23
@atanmarko atanmarko requested a review from gruberb November 8, 2023 14:24
Copy link
Contributor

@gruberb gruberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/topos/src/components/node/mod.rs Outdated Show resolved Hide resolved
@atanmarko atanmarko merged commit 4799cce into main Nov 9, 2023
@atanmarko atanmarko deleted the fix/genesis_file_error branch November 9, 2023 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants