Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: cleanup dial related functionality #377

Merged
merged 4 commits into from
Nov 22, 2023
Merged

chore: cleanup dial related functionality #377

merged 4 commits into from
Nov 22, 2023

Conversation

atanmarko
Copy link
Member

Description

Cleanup unused dial related functionality. Removed unnecessary peer/listener tracking in p2p crate.

Fixes TP-732

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Nov 20, 2023
@atanmarko atanmarko requested a review from a team as a code owner November 20, 2023 10:32
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (c70bfad) 62.60% compared to head (17b9b2b) 62.88%.
Report is 1 commits behind head on main.

Files Patch % Lines
crates/topos-tce/src/app_context/network.rs 64.04% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   62.60%   62.88%   +0.28%     
==========================================
  Files         218      218              
  Lines       11874    11821      -53     
==========================================
  Hits         7434     7434              
+ Misses       4440     4387      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko atanmarko merged commit ea18039 into main Nov 22, 2023
17 checks passed
@atanmarko atanmarko deleted the chore/TP-732 branch November 22, 2023 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants