Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: adding context on connection to self #413

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

Freyskeyd
Copy link
Member

Description

Adding some more context to the node bootstrap in order to better understand the soft-fork flow.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner December 18, 2023 15:12
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2023

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the chore/adding-more-context-to-bootstrap branch from db953a9 to 2fdfca2 Compare December 18, 2023 15:13
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a799ac) 65.36% compared to head (2fdfca2) 65.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   65.36%   65.74%   +0.37%     
==========================================
  Files         223      223              
  Lines       11900    11921      +21     
==========================================
+ Hits         7779     7838      +59     
+ Misses       4121     4083      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd merged commit 6e72999 into main Dec 18, 2023
23 checks passed
@Freyskeyd Freyskeyd deleted the chore/adding-more-context-to-bootstrap branch December 18, 2023 15:54
@Freyskeyd Freyskeyd added this to the Soft-fork investigation milestone Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants