Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: update signal handle by tce #417

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

Freyskeyd
Copy link
Member

@Freyskeyd Freyskeyd commented Dec 19, 2023

Description

Update the TCE to catch SIGTERM signal coming from the OS

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner December 19, 2023 17:59
@Freyskeyd Freyskeyd requested review from dvdplm and gruberb and removed request for a team December 19, 2023 17:59
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6e72999) 65.71% compared to head (5e9def2) 67.25%.
Report is 1 commits behind head on main.

Files Patch % Lines
crates/topos/src/components/node/mod.rs 50.00% 1 Missing ⚠️
crates/topos/tests/utils.rs 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   65.71%   67.25%   +1.54%     
==========================================
  Files         223      223              
  Lines       11921    11923       +2     
==========================================
+ Hits         7834     8019     +185     
+ Misses       4087     3904     -183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a test for this (this == shutdown), but it'd have to be an e2e test I believe.

@Freyskeyd Freyskeyd marked this pull request as draft December 20, 2023 12:49
@Freyskeyd Freyskeyd self-assigned this Dec 20, 2023
@Freyskeyd Freyskeyd marked this pull request as ready for review December 20, 2023 12:50
@Freyskeyd Freyskeyd changed the base branch from chore/updating-double-echo-devnet to main December 20, 2023 12:50
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the chore/update-signal-handled-by-tce branch from 289864b to 04c1af6 Compare December 20, 2023 12:51
@Freyskeyd Freyskeyd added this to the Soft-fork investigation milestone Dec 20, 2023
@Freyskeyd
Copy link
Member Author

@dvdplm Yes I don't know if it is really possible to unit tests the signal handling on that part, sending the SIGTERM to the current PID would just kill the test process I think?

@Freyskeyd Freyskeyd force-pushed the chore/update-signal-handled-by-tce branch from 1e1df53 to d72275f Compare December 20, 2023 17:02
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the chore/update-signal-handled-by-tce branch from d72275f to 5e9def2 Compare December 20, 2023 17:06
@Freyskeyd Freyskeyd merged commit beca28b into main Dec 20, 2023
20 checks passed
@Freyskeyd Freyskeyd deleted the chore/update-signal-handled-by-tce branch December 20, 2023 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants