Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: adding positions to certificate #440

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Freyskeyd
Copy link
Member

Description

This PR adds positions to Certificate in GraphQL response.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner January 25, 2024 12:58
@Freyskeyd Freyskeyd changed the base branch from main to feature/tp-761/reorganization January 25, 2024 12:58
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Freyskeyd Freyskeyd force-pushed the feature/tp-761/adding-positions branch from 5c4d103 to 239a3e0 Compare January 25, 2024 14:52
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4b0ec9b) 67.98% compared to head (91c872f) 68.33%.

Files Patch % Lines
crates/topos-tce-api/src/graphql/query.rs 25.00% 3 Missing ⚠️
crates/topos-tce-api/src/runtime/mod.rs 75.00% 2 Missing ⚠️
crates/topos-core/src/api/graphql/certificate.rs 87.50% 1 Missing ⚠️
crates/topos-tce-api/src/runtime/sync_task.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   67.98%   68.33%   +0.34%     
==========================================
  Files         224      224              
  Lines       13129    13152      +23     
==========================================
+ Hits         8926     8987      +61     
+ Misses       4203     4165      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feature/tp-761/reorganization to main January 25, 2024 15:46
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the feature/tp-761/adding-positions branch from 239a3e0 to 91c872f Compare January 25, 2024 16:15
@Freyskeyd Freyskeyd merged commit 5315710 into main Jan 25, 2024
21 checks passed
@Freyskeyd Freyskeyd deleted the feature/tp-761/adding-positions branch January 25, 2024 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants