Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: introduce topos-config crate #443

Merged
merged 2 commits into from
Jan 31, 2024
Merged

feat: introduce topos-config crate #443

merged 2 commits into from
Jan 31, 2024

Conversation

Freyskeyd
Copy link
Member

Description

This PR introduces a new crate topos-config which will provide struct for the different configuration across the various crates.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (917eaf9) 66.13% compared to head (a917c03) 68.92%.
Report is 2 commits behind head on main.

Files Patch % Lines
crates/topos/src/components/node/mod.rs 60.00% 4 Missing ⚠️
crates/topos-tce/src/lib.rs 77.77% 2 Missing ⚠️
crates/topos-config/src/tce.rs 85.71% 1 Missing ⚠️
...ates/topos/src/components/node/services/process.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
+ Coverage   66.13%   68.92%   +2.78%     
==========================================
  Files         224      220       -4     
  Lines       13152    12141    -1011     
==========================================
- Hits         8698     8368     -330     
+ Misses       4454     3773     -681     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd marked this pull request as ready for review January 30, 2024 07:00
@Freyskeyd Freyskeyd requested a review from a team as a code owner January 30, 2024 07:00
@Freyskeyd Freyskeyd requested review from dvdplm and gruberb January 30, 2024 07:00
crates/topos-config/src/lib.rs Outdated Show resolved Hide resolved
crates/topos-config/src/node.rs Outdated Show resolved Hide resolved
crates/topos-config/src/tce.rs Show resolved Hide resolved
crates/topos-tce/src/lib.rs Show resolved Hide resolved
crates/topos-config/src/node.rs Outdated Show resolved Hide resolved
@Freyskeyd Freyskeyd force-pushed the feature/tp-844 branch 2 times, most recently from 680107c to e896dc6 Compare January 30, 2024 10:32
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd merged commit 4ff2a23 into main Jan 31, 2024
20 checks passed
@Freyskeyd Freyskeyd deleted the feature/tp-844 branch January 31, 2024 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants