Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: move telemetry-otlp setup into telemetry crate #446

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

Freyskeyd
Copy link
Member

Description

For consistency and further use, move the otlp related configuration setup to topos-telemetry.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner February 1, 2024 10:20
@Freyskeyd Freyskeyd requested review from gruberb and JDawg287 and removed request for a team February 1, 2024 10:20
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (62126e0) 68.79% compared to head (ab72e67) 68.92%.
Report is 3 commits behind head on main.

❗ Current head ab72e67 differs from pull request most recent head cda0d02. Consider uploading reports for the commit cda0d02 to get more accurate results

Files Patch % Lines
crates/topos/src/components/regtest/mod.rs 0.00% 7 Missing ⚠️
crates/topos-telemetry/src/tracing.rs 40.00% 3 Missing ⚠️
crates/topos-telemetry/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   68.79%   68.92%   +0.13%     
==========================================
  Files         220      222       +2     
  Lines       12146    12137       -9     
==========================================
+ Hits         8356     8366      +10     
+ Misses       3790     3771      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd force-pushed the refactor/edge-config-to-config branch from 35a82bf to 22a0ec5 Compare February 8, 2024 17:44
Base automatically changed from refactor/edge-config-to-config to main February 8, 2024 18:54
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the chore/move-telemetry-otlp branch from ab72e67 to cda0d02 Compare February 8, 2024 18:54
@Freyskeyd Freyskeyd merged commit 8a15fc4 into main Feb 8, 2024
19 checks passed
@Freyskeyd Freyskeyd deleted the chore/move-telemetry-otlp branch February 8, 2024 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants