This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freyskeyd
force-pushed
the
refactor/store-instantiation
branch
from
March 1, 2024 20:57
6166fda
to
9f81725
Compare
Freyskeyd
force-pushed
the
feature/tec-23
branch
2 times, most recently
from
March 1, 2024 21:34
93d26bc
to
556d295
Compare
Freyskeyd
force-pushed
the
refactor/store-instantiation
branch
from
March 5, 2024 09:54
9f81725
to
9e27632
Compare
Freyskeyd
force-pushed
the
feature/tec-23
branch
2 times, most recently
from
March 6, 2024 09:49
01afb73
to
7d06abf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
+ Coverage 70.70% 71.60% +0.89%
==========================================
Files 225 225
Lines 12410 12504 +94
==========================================
+ Hits 8775 8953 +178
+ Misses 3635 3551 -84 ☔ View full report in Codecov by Sentry. |
Freyskeyd
force-pushed
the
feature/tec-23
branch
4 times, most recently
from
March 6, 2024 20:49
99a6d84
to
47fa328
Compare
dvdplm
reviewed
Mar 7, 2024
hadjiszs
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also saw several occurrences "bootpeers" and "bootnodes" maybe let's try to stick to one or you wanna actually keep distinction for some reason?
Freyskeyd
force-pushed
the
feature/tec-23
branch
from
March 12, 2024 09:09
d8486fd
to
3f3afaf
Compare
dvdplm
approved these changes
Mar 12, 2024
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Freyskeyd
force-pushed
the
feature/tec-23
branch
from
March 12, 2024 15:08
3f3afaf
to
addf486
Compare
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Freyskeyd
force-pushed
the
feature/tec-23
branch
from
March 12, 2024 15:10
addf486
to
6490712
Compare
4 tasks
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding and refactoring how the node will setup and validate it's p2p layer connectivity.
It is a first step to allow nodes to be spawn in any order and gain more confidence on the node status.
Changes
discovery
behaviour will periodically walk the network to find new peers and discover more nodes.gossip
behaviour will subscribe to different topics and become healthy when at least one is okhandle_event
method of the P2Pruntime
is returning aResult
which allows us to report error (and maybe crash) if needed.StateMachine
in P2P layer represents a struct that hold state projection (to avoid extra calculation), it may be refactored toenum
and better integrated with the events but for now it is enough.Steps
listening
and exposing its addresses.discovery
behaviour will initiatebootstrap
query targeting the bootnode.The connection and result of this query will define if we go or not to the next step.
gossipsub
behaviour will then trigger thesubscribe
to the topicsPR Checklist: