This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
net: Fixes made during works on k8s testbed stabilization #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpasirst
reviewed
Jul 26, 2022
| Err(e) => log::debug!("Dial {:?} failed: {:?}", &known_peer.1, e), | ||
| } | ||
| } | ||
| // for known_peer in config.known_peers.clone() { |
There was a problem hiding this comment.
Not sure how others feel, but usually, if commenting out code and leaving it in the file, I suggest including a description as to why this was done so when either you come back later or another engineer looks at it, they understand why the code still exists just disabled. E.g. "This code is for preparation of launching and support the gossip protocol, for now (<today's date>) it is disabled since we are not yet ready for it."
Freyskeyd
reviewed
Jul 29, 2022
axb-topos
added a commit
that referenced
this pull request
Aug 10, 2022
hadjiszs
pushed a commit
that referenced
this pull request
Aug 11, 2022
* chore: tools ci bug fixes to make k8s run correctly chore: remove cert-spammer from the workspace Removed cert-spammer from the workspace feat: add 2 hrs timeout on the swarm connections chore: update the addresses on docker feat: add broadcast params as cli args and misc doc chore: update addresses on docker-compose fix: make sampler handling border cases no panic should be raised now feat: gossip to reunion of all the samples fix: fix kad and early sampling on non-boot node chore: bump tokio to 1.20.0 fix: make request/response correct for kad test: add db-path for kad test launcher refactor: remove ext_req_id from NetworkCommands feat: remove following of subnets on memstore test: update static cert submitter chore: add pull_policy on docker compose test: modify kad test and utility cert sender * style: clippy warnings * chore: dockerfile creds for private deps * test: changed launching of the app * test: changed timings of async testing (not good anyway) * test: changed timings of async testing (not good anyway) * test: commented out timing dependent unit tests * test: put all the local testing snippets into single file * chore: code-review fixes from PR #8 * chore: code-review fixes from PR #9 * chore: code-review fixes from PR #10
hadjiszs
pushed a commit
that referenced
this pull request
Mar 9, 2023
* chore: tools ci bug fixes to make k8s run correctly chore: remove cert-spammer from the workspace Removed cert-spammer from the workspace feat: add 2 hrs timeout on the swarm connections chore: update the addresses on docker feat: add broadcast params as cli args and misc doc chore: update addresses on docker-compose fix: make sampler handling border cases no panic should be raised now feat: gossip to reunion of all the samples fix: fix kad and early sampling on non-boot node chore: bump tokio to 1.20.0 fix: make request/response correct for kad test: add db-path for kad test launcher refactor: remove ext_req_id from NetworkCommands feat: remove following of subnets on memstore test: update static cert submitter chore: add pull_policy on docker compose test: modify kad test and utility cert sender * style: clippy warnings * chore: dockerfile creds for private deps * test: changed launching of the app * test: changed timings of async testing (not good anyway) * test: changed timings of async testing (not good anyway) * test: commented out timing dependent unit tests * test: put all the local testing snippets into single file * chore: code-review fixes from PR #8 * chore: code-review fixes from PR #9 * chore: code-review fixes from PR #10
hadjiszs
pushed a commit
that referenced
this pull request
Mar 9, 2023
* chore: tools ci bug fixes to make k8s run correctly chore: remove cert-spammer from the workspace Removed cert-spammer from the workspace feat: add 2 hrs timeout on the swarm connections chore: update the addresses on docker feat: add broadcast params as cli args and misc doc chore: update addresses on docker-compose fix: make sampler handling border cases no panic should be raised now feat: gossip to reunion of all the samples fix: fix kad and early sampling on non-boot node chore: bump tokio to 1.20.0 fix: make request/response correct for kad test: add db-path for kad test launcher refactor: remove ext_req_id from NetworkCommands feat: remove following of subnets on memstore test: update static cert submitter chore: add pull_policy on docker compose test: modify kad test and utility cert sender * style: clippy warnings * chore: dockerfile creds for private deps * test: changed launching of the app * test: changed timings of async testing (not good anyway) * test: changed timings of async testing (not good anyway) * test: commented out timing dependent unit tests * test: put all the local testing snippets into single file * chore: code-review fixes from PR #8 * chore: code-review fixes from PR #9 * chore: code-review fixes from PR #10
hadjiszs
pushed a commit
that referenced
this pull request
Mar 9, 2023
* chore: tools ci bug fixes to make k8s run correctly chore: remove cert-spammer from the workspace Removed cert-spammer from the workspace feat: add 2 hrs timeout on the swarm connections chore: update the addresses on docker feat: add broadcast params as cli args and misc doc chore: update addresses on docker-compose fix: make sampler handling border cases no panic should be raised now feat: gossip to reunion of all the samples fix: fix kad and early sampling on non-boot node chore: bump tokio to 1.20.0 fix: make request/response correct for kad test: add db-path for kad test launcher refactor: remove ext_req_id from NetworkCommands feat: remove following of subnets on memstore test: update static cert submitter chore: add pull_policy on docker compose test: modify kad test and utility cert sender * style: clippy warnings * chore: dockerfile creds for private deps * test: changed launching of the app * test: changed timings of async testing (not good anyway) * test: changed timings of async testing (not good anyway) * test: commented out timing dependent unit tests * test: put all the local testing snippets into single file * chore: code-review fixes from PR #8 * chore: code-review fixes from PR #9 * chore: code-review fixes from PR #10
gruberb
added a commit
that referenced
this pull request
Jun 8, 2023
# This is the 1st commit message: Moved grpc files to topos-api/grpc folder, created graphql folder # This is the commit message #2: Add routes and the query # This is the commit message #3: WIP # This is the commit message #4: Move logic around, cargo fmt # This is the commit message #5: Build and run graphql server # This is the commit message #6: Cleanup # This is the commit message #7: Exposing ports # This is the commit message #8: Debugging # This is the commit message #9: Debugging # This is the commit message #10: Fix tests # This is the commit message #11: Success: Exposed running GraphQL server
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.