This repository has been archived by the owner on Jan 17, 2025. It is now read-only.
Fix ActiveSupport dependency #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change sets the version of ActiveSupport required to be less than 5, this allows more ruby versions to support the gem
|
Ugh, the build fails for Ruby 1.9.3 - https://travis-ci.org/toptal/disqus_api/jobs/225392772 It's really strange, because rspec 3.5.0 supports Ruby v1.8.7 and greater 🤔 |
|
It was actually caused by a strange bundler error, see rubygems/bundler#3558, more specifically rubygems/bundler#3558 (comment) I updated .travis.yml with the suggested fix. |
|
thank you very much @cmattrex ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change sets the version of ActiveSupport required to be less than 5, this allows more ruby versions to support the gem.
cc @einzige
This should be really straightforward. It should fix the failing builds and allow more ruby versions to support the gem.
Can you please tag the new version and bump the RubyGems release?