-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-5880] Update PageHead to follow BASE #4529
Conversation
🦋 Changeset detectedLatest commit: 53b0311 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
105203c
to
8a4fcfe
Compare
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
|
@toptal-anvil ping reviewers |
@toptal-anvil ping reviewers |
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
@toptal-anvil ping reviewers |
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks nice and works as expected, great job!
packages/base/Page/src/PageHeadBase/story/WithEnabledMinHeight.example.tsx
Outdated
Show resolved
Hide resolved
I approve |
FX-5880
Description
This PR adds a new
PageHeadBase
component to conform to BASE. This will replacePageHead
which is deprecated and will be removed in a future major release of Picasso.tailwindcss
has been updated to>=4.10
, so it can allow proper use of the new TailwindCSS features likehas-[]
.Note: This PR will have a follow-up ticket to ensure that the new component can be adopted into
StaffPortal
.How to test
Screenshots
mobile version
Development checks
picasso-tailwind-merge
requires major update (check itsREADME.md
)props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?