Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-6025] Fix micromatch vulneralility #4593

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

ruslan-sed
Copy link
Contributor

@ruslan-sed ruslan-sed commented Oct 3, 2024

FX-6025

Description

I used resolutions because investigating yarn.lock I found out that it @storybook/react@^6.5.15 in the end was the reason for having micromatch of version 3.1.10. Installed version of @storybook/react was already the highest possible - 6.5.16. The next highest is version 7, and we can't update to this version right now. Attempts to reinstall the chain of parents leading from mistatch to @storybook/react also did not work.

But I cant be 100% sure that some other way can be used instead of resolution.

How to test

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@ruslan-sed ruslan-sed self-assigned this Oct 3, 2024
Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: 506b262

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ruslan-sed ruslan-sed force-pushed the fx-6025-fix-micromatch-vulnerability branch from eb4d669 to 2575d21 Compare October 3, 2024 14:47
package.json Outdated Show resolved Hide resolved
@ruslan-sed ruslan-sed marked this pull request as ready for review October 4, 2024 09:27
@ruslan-sed ruslan-sed requested a review from a team October 4, 2024 09:27
@ruslan-sed
Copy link
Contributor Author

@toptal-anvil ping reviewers

@ruslan-sed ruslan-sed force-pushed the fx-6025-fix-micromatch-vulnerability branch from d927142 to 57fc20a Compare October 8, 2024 12:34
@ruslan-sed ruslan-sed force-pushed the fx-6025-fix-micromatch-vulnerability branch from 57fc20a to 506b262 Compare October 8, 2024 12:37
@TomasSlama TomasSlama requested a review from a team October 8, 2024 13:56
@AdrianContiu AdrianContiu self-requested a review October 8, 2024 14:22
Copy link
Contributor

@AdrianContiu AdrianContiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks are green except for a known Happo-Cypress error related to Slider tooltips. However, I checked temploy and everything seems to be working fine, including the Slider Tooltip story.

@ruslan-sed ruslan-sed merged commit bdcc9b0 into master Oct 9, 2024
18 checks passed
@ruslan-sed ruslan-sed deleted the fx-6025-fix-micromatch-vulnerability branch October 9, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants