-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-6025] Fix micromatch vulneralility #4593
Conversation
|
eb4d669
to
2575d21
Compare
@toptal-anvil ping reviewers |
d927142
to
57fc20a
Compare
57fc20a
to
506b262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checks are green except for a known Happo-Cypress error related to Slider tooltips. However, I checked temploy and everything seems to be working fine, including the Slider Tooltip story.
FX-6025
Description
I used
resolutions
because investigatingyarn.lock
I found out that it@storybook/react@^6.5.15
in the end was the reason for havingmicromatch
of version3.1.10
. Installed version of@storybook/react
was already the highest possible -6.5.16
. The next highest is version 7, and we can't update to this version right now. Attempts to reinstall the chain of parents leading frommistatch
to@storybook/react
also did not work.But I cant be 100% sure that some other way can be used instead of resolution.
How to test
Development checks
Add changeset according to guidelines (if needed)Double check ifpicasso-tailwind-merge
requires major update (check itsREADME.md
)Read CONTRIBUTING.md and Component API principlesMake sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-coreAnnotate allprops
in component with documentationCreateexamples
for componentEnsure that deployed demo has expected results and good examplesEnsure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.Covered with tests (visual tests included)Breaking change
codemod is created and showcased in the changesettest alpha package of Picasso in StaffPortalPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?