close #382 Leniently handle high dpi causing maximum image dimensions…

… to be exceeded
torakiki · Jul 27, 2020 · e0e0824 · e0e0824
1 parent 008f080
commit e0e0824
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 1 deletion.
diff --git a/sejda-core/src/test/java/org/sejda/core/service/PdfToMultipleJpegTaskTest.java b/sejda-core/src/test/java/org/sejda/core/service/PdfToMultipleJpegTaskTest.java
@@ -66,4 +66,18 @@ public void noPages() throws IOException {
         execute(parameters);
         testContext.assertTaskFailed("No pages converted");
     }
+
+    @Test
+    public void dpiExceedsJavaMaxBufferedImageSize() throws IOException {
+        PdfToJpegParameters parameters = new PdfToJpegParameters(ImageColorType.COLOR_RGB);
+        parameters.setResolutionInDpi(6000);
+        parameters.addPageRange(PageRange.one(1));
+        parameters.setLenient(true);
+        parameters.addSource(shortInput());
+        testContext.directoryOutputTo(parameters);
+
+        execute(parameters);
+        testContext.assertTaskCompleted();
+        testContext.assertTaskWarning("Maximum image dimensions exceeded on page 1, decreased resolution to 116 dpi");
+    }
 }
diff --git a/sejda-sambox/src/main/java/org/sejda/impl/sambox/PdfToMultipleImageTask.java b/sejda-sambox/src/main/java/org/sejda/impl/sambox/PdfToMultipleImageTask.java
@@ -40,6 +40,8 @@
 import org.sejda.model.input.PdfSourceOpener;
 import org.sejda.model.parameter.image.AbstractPdfToMultipleImageParameters;
 import org.sejda.model.task.TaskExecutionContext;
+import org.sejda.sambox.pdmodel.PDPage;
+import org.sejda.sambox.pdmodel.common.PDRectangle;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -98,8 +100,34 @@ public void execute(T parameters) throws TaskException {
 
                         try {
                             LOG.trace("Converting page {}", currentPage);
+                            int dpi = parameters.getResolutionInDpi();
+                            float scale = dpi / 72f;
+
+                            // check if the page at the specified dpi resolution does not exceed 
+                            // max java buffered image dimensions
+                            PDPage page = documentHandler.getPage(currentPage);
+
+                            PDRectangle cropbBox = page.getCropBox();
+                            float widthPt = cropbBox.getWidth();
+                            float heightPt = cropbBox.getHeight();
+
+                            int widthPx = (int) Math.max(Math.floor(widthPt * scale), 1);
+                            int heightPx = (int) Math.max(Math.floor(heightPt * scale), 1);
+
+                            // the maximum size (w*h) of a buffered image is limited to Integer.MAX_VALUE
+                            if ((long) widthPx * (long) heightPx > Integer.MAX_VALUE) {
+                                float decreaseRatio = widthPt * heightPt * scale / Integer.MAX_VALUE;
+                                dpi = (int) Math.round(Math.floor(dpi * decreaseRatio));
+                                Exception e = new RuntimeException(
+                                        String.format("Maximum image dimensions exceeded on page %d", currentPage));
+                                executionContext().assertTaskIsLenient(e);
+                                notifyEvent(executionContext().notifiableTaskMetadata()).taskWarning(
+                                        String.format("Maximum image dimensions exceeded on page %d, decreased resolution to %d dpi",
+                                                currentPage, dpi), e);
+                            }
+
                             BufferedImage pageImage = documentHandler.renderImage(currentPage,
-                                    parameters.getResolutionInDpi(), parameters.getOutputImageColorType());
+                                    dpi, parameters.getOutputImageColorType());
 
                             getWriter().openDestination(tmpFile, parameters);
                             getWriter().write(pageImage, parameters);