Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for ember v3.1 compatability #87

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Conversation

toranb
Copy link
Owner

@toranb toranb commented Apr 18, 2018

As of ember v3.1 the Proxy used by core object runs a strict assertion that in turns throws the error

Since Ember 3.1, this is usually fine as you no longer need to use `.get()` to access computed properties. However, in this case, the object in question is a special kind of Ember object (a proxy). Therefore, it is still necessary to use `.get('X')` in this case

Robert Jackson was able to further identify this after I submitted an issue a few days back ;)

While this PR isn't anything I'm extremely happy about, it does offer a workaround for anyone upgrading to ember v3.1. I'm planning to submit a more correct fix to ember core itself based on the feedback

@toranb toranb merged commit 9d08d5c into master Apr 18, 2018
@toranb
Copy link
Owner Author

toranb commented Apr 21, 2018

emberjs/ember.js#16560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant