Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possibly type error in private data redaction #126

Merged
merged 1 commit into from
Mar 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion custom_components/e3dc_rscp/diagnostics.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"""Diagnostics support for E3DC RSCP."""

from __future__ import annotations

from collections.abc import Callable
Expand Down Expand Up @@ -124,6 +125,10 @@ def _redact_private_information(self, data: Any):
for key, value in (
data.items() if isinstance(data, dict) else enumerate(data)
):
if isinstance(value, str) and _redact_regex.search(key) is not None:
if (
isinstance(value, str)
and isinstance(key, str)
and _redact_regex.search(key) is not None
):
data[key] = f"{value[:3]}<redacted>"
self._redact_private_information(value)
Loading