Skip to content

Fix installing torch points kernels with latest pip #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Fix installing torch points kernels with latest pip #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f170d9
Fix installing torch points kernels with latest pip
nicolas-chaulet Apr 28, 2020
812da6d
Update docs
nicolas-chaulet Apr 28, 2020
5ea08f6
Fix optimisation flag
nicolas-chaulet Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
# Unreleased

# 0.5.3

## Update
- ball query returns squared distance instead of distance
- leaner Point Cloud struct that avoids copying data

## Bug fix
- Pcakage would not install if pytorch is not already installed
2 changes: 2 additions & 0 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
include README.md
include LICENSE
include CHANGELOG.md
include pyproject.toml

recursive-exclude test *
recursive-include cpu *
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ exclude = '''
'''

[build-system]
requires = ["setuptools>=41.0", "setuptools-scm", "wheel"]
requires = ["setuptools>=41.0", "setuptools-scm", "wheel", "torch"]
build-backend = "setuptools.build_meta"
10 changes: 7 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

TORCH_MAJOR = int(torch.__version__.split(".")[0])
TORCH_MINOR = int(torch.__version__.split(".")[1])
extra_compile_args = []
extra_compile_args = ["-O3"]
if (TORCH_MAJOR > 1) or (TORCH_MAJOR == 1 and TORCH_MINOR > 2):
extra_compile_args += ["-DVERSION_GE_1_3"]

Expand Down Expand Up @@ -48,7 +48,7 @@
requirements = ["torch>=1.1.0"]

url = 'https://github.com/nicolas-chaulet/torch-points-kernels'
__version__="0.5.2"
__version__="0.5.3"
setup(
name="torch-points-kernels",
version=__version__,
Expand All @@ -60,5 +60,9 @@
ext_modules=ext_modules,
cmdclass={"build_ext": BuildExtension},
long_description=long_description,
long_description_content_type='text/markdown'
long_description_content_type='text/markdown',
classifiers=[
"Programming Language :: Python :: 3",
"License :: OSI Approved :: MIT License",
],
)