Fix bug with negative index accessing random memory #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humanpose1
approved these changes
May 14, 2020
Collaborator
humanpose1
left a comment
humanpose1
left a comment
There was a problem hiding this comment.
Good Catch ! that's weird that there is the problem in colab but not in our computer.
Collaborator
|
You should also maybe update the readme ... |
Member
Author
|
I have added a note in the changelog, it shoulud be the goto place to know what has changed in the code. We do the same on torch-points3d now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was working perfectly until we used it on Google colab. Something must be different there, it did not like negative index in accessors at all on cpu...