add missing <memory> header to allow building with GCC12 #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some C++ Standard Library headers have been changed to no longer include
other headers that were being used internally by the library since
GCC12[^1]. As a result, building torch-points-kernels with GCC12 fails
with message:
cpu/src/neighbors.cpp:317:10: error: ‘unique_ptr’ is not a member of ‘std’
317 | std::unique_ptr<my_kd_tree_t> index(new my_kd_tree_t(3, pcd, tree_params));
| ^~~~~~~~~~
cpu/src/neighbors.cpp:317:10: note: ‘std::unique_ptr’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
This pr adds the missing `<memory>` header to `cpu/src/neighbors.cpp` to
allow building with GCC12.
[^1]: <https://gcc.gnu.org/gcc-12/porting_to.html#header-dep-changes>
Signed-off-by: Gaoyang Zhang <gy@blurgy.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some C++ Standard Library headers have been changed to no longer include other headers that were being used internally by the library since GCC121. As a result, building torch-points-kernels with GCC12 fails with message:
This pr adds the missing
<memory>header tocpu/src/neighbors.cppto allow building with GCC12.Signed-off-by: Gaoyang Zhang gy@blurgy.xyz
Footnotes
https://gcc.gnu.org/gcc-12/porting_to.html#header-dep-changes ↩