Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden dependency on torch #23

Closed
HeinrichHartmann opened this issue Feb 26, 2017 · 1 comment
Closed

Hidden dependency on torch #23

HeinrichHartmann opened this issue Feb 26, 2017 · 1 comment

Comments

@HeinrichHartmann
Copy link
Contributor

Howdy,

I installed this module without torch, but got this error trying to user path.iterfiles():

init.lua:28: attempt to index global 'torch' (a nil value)

Also, torch is not an explicity dependency.

I find this module quite useful as stand-alone. Hope this is an intended use case.
@HeinrichHartmann
Copy link
Contributor Author

This seems to be the only place the torch object is used.

soumith added a commit that referenced this issue Feb 26, 2017
@soumith
Merge pull request #24 from HeinrichHartmann/pr-no-torch
4ebe222 
Fix #23: Use type instead of torch.type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HeinrichHartmann