Support/wagtail 63 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow Django 5.1 - Drop Django 3.2 - Add Python 3.13 - Drop Python 3.8 - Add Wagtail 6.3 - Drop Wagtail 6.1 - Drop Wagtail 6.0
nickmoreton
commented
Nov 27, 2024
| wagtail>=5.2 | ||
| django-debug-toolbar==3.2.2 | ||
| django-debug-toolbar==4.4.6 |
There was a problem hiding this comment.
The update here was because Django 5.1 needs a more recent version of debug toolbar
| @@ -3,7 +3,12 @@ Unreleased | |||
| - Add support for Wagtail 5.2 and 6.x | |||
| - Drop support for Wagtail < 5.2 | |||
| - Update `otp_form` to be compatible with Wagtail 5.2 and 6.x | |||
| - Add support for Django 5.0 | |||
| - Add support for Django 5.0 (currently 5.1 is broken in example app) | |||
There was a problem hiding this comment.
Question: Are there any implications to Django 5.1 being broken in example app? I understand that the package still "works" with 5.1?
There was a problem hiding this comment.
@JakubMastalerz This was something I saw when I first tested the example app but I remember once i'd updated everything that problem went away and I think I forgot to update the comment here.
Do you see any issues with it when you run make sandbox
My feeling is that it was fixed when I made the changes in: sandbox/requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important changes include updating the Python and Django versions in various configuration files and ensuring compatibility with the latest versions of Wagtail.
Dependency and compatibility updates:
.github/workflows/python-tox.yml: Updated the Python versions matrix to include Python 3.13 and removed Python 3.8.CHANGES: Updated to reflect the addition of support for Django 5.1 and Python 3.13, and the removal of support for Django 3.2 and Python 3.8.setup.py: Updated theinstall_requiresto require Django 4.2 or later and added classifiers for Django 5.1 and Python 3.13. [1] [2]sandbox/requirements.txt: Updated to require Django 4.2 or later and updateddjango-debug-toolbarto version 4.4.6.Testing configuration updates:
tox.ini: Updated theenvlistanddepssections to include newer versions of Django and Wagtail, and removed configurations for older versions.