Hot fixes django upgrades #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate missing migration at django4.0
- Pin isort and black to lower versions to avoid breaking the CI - Removes flake8 from the envlist. - I'm don't think it is actually needed in the envlist, as it is not a - test environment. It is also not used in the CI pipeline. - The actions pipeline was failing with it present. - Revise test matrix - Missing py312 in tox.ini - Action needs python 3.12 - Comment out the Django 5.0 - Upgrade actions versions to latest - Block artifacts upload for now
nickmoreton
force-pushed
the
hot-fixes-django-upgrades
branch
from
10aef7f
to
9204a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
I think this should be kept around for the moment and worked on again once the Wagtail 5.2 upgrade is deployed to production for OxfanGB
The reason it that reverse engineering this package to use in a site with django 4+ is hard. This is because there are migrations required in the package.
The package can install wagtail up to 5.2 and django up to 5.0. I could make separate branches for each step but it will be time consuming to do that.
The approach to take is once Oxfam GB is deployed we will make a version of this package only for that site. We don't use the package anywhere else. Another option could be to move the whole package into the OxfamGB site as an app and modify it there.