Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on pattern context customisation in base template #111

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

thibaudcolas
Copy link
Member

Documents how to edit the base template to make it display differently for pattern library components only. This was mentioned on Slack by @nicklee. Also goes some of the way towards #86.

Type of change

Documentation only.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@thibaudcolas thibaudcolas added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 7, 2020
@thibaudcolas thibaudcolas added this to the Nice to have milestone Apr 7, 2020
Copy link
Member

@nicklee nicklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, looks great; all makes sense to me :)

@thibaudcolas thibaudcolas merged commit 5b12ca8 into master Apr 7, 2020
@thibaudcolas thibaudcolas deleted the chore/pattern-context-base-template branch April 7, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants