Context modifiers: Search for context_modifiers.py in registered Django apps #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @thibaudcolas on #141 - context modifiers registered in
pattern_contexts.py
(as indicated in docs) are not being picked up, because nothing is currently loading those modules.I quite like the idea of using
pattern_contexts.py
as a pattern in apps, so these changes trigger a search for such modules whenget_for_template()
is first used (as late as possible, to avoid 'app not yet loaded' issues)Checklist