Skip to content

Fix pattern name URL regex to account for Windows paths with backslash. Fix #222 #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

reedjones
Copy link
Contributor

@reedjones reedjones commented Apr 23, 2023

Description

Fixed url pattern regex to account for windows paths
Fixes # (issue)

#222

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @reedjones! I don’t have a way to test this on Windows at the moment unfortunately, but your report in #222 and the changes here make sense to me, and seem to work fine on macOS – so let’s proceed with this.

@thibaudcolas thibaudcolas changed the title fixed regex to account for windows paths Fix pattern name URL regex to account for Windows paths with backslash. Fix #222 Aug 18, 2023
@thibaudcolas thibaudcolas merged commit a6d58a1 into torchbox:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants