fix: make it work for django5.0 (updated) #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
reviewed
Jan 16, 2024
| @@ -15,7 +15,7 @@ jobs: | |||
| python-version: "3.11" | |||
| cache: 'poetry' | |||
| - run: pip install tox | |||
| - run: tox -e lint,py311-dj42 | |||
| - run: tox -e lint,py311-dj50 | |||
There was a problem hiding this comment.
nitpick: test_compatibility below stats "Test with all supported Django versions, for all compatible Python versions." and includes 4.2 and main. Would be nice to update it to include 5.0, but that is not a blocker
CuriousLearner
added a commit
to lincolnloop/django-pattern-library
that referenced
this pull request
Feb 24, 2024
…rary into jinja * 'main' of https://github.com/torchbox/django-pattern-library: Add Python 3.12 to the test matrix, drop Django 4.1 (torchbox#242) Updates for version 1.2.0 Improve handling of non-string values for 'override_tag's 'default_html' argument (torchbox#224) fix: make it work for django5.0 (updated) (torchbox#241) Upgrade GitHub Actions versions (torchbox#237) Fix typos discovered by codespell (torchbox#238)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacement PR to fix #235 , to rebase the original PR #236 for CI fixes
Please include a summary of the changes and which issue this relates to (if applicable).
Fixes # (issue)
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas(N/A)[ ] I have made corresponding changes to the documentation(N/A)