This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Switch from Nodesource scripts to nvm for installing Node.js #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes Made
Nodesource will no longer be using the installation scripts that we've been using for a while. You've probably already come across the deprecation notice when buiding containers:
Rather than switching to the new installation process, this MR updates the setup to use nvm.
I have also added a commit to ensure consistency of Node versions between
.nvmrc
file andDockerfile
.How to Test
Follow the build instructions in the README. Once the containers are built, SSH into the
web
container viafab sh
and check thatnode
andnpm
commands are available, for instance:MR Checklist
Consider adding unit tests, especially for bug fixes. If you don't, tell us why.N/AConsider updating documentation. If you don't, tell us why.N/AIf relevant, list the environments / browsers in which you tested your changes.N/A