upgrade edit_handlers API to 2.0 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pahacofome, I've just merged a PR for Wagtail 2.4/2.5 compatibility, that does not include those changes. Do you think this API update is still relevant? I'm assuming it is, but I'm not sure I fully understand what's involved. Edit: looks like the corresponding issue is #34. |
thibaudcolas
added a commit
to pahacofome/wagtailmedia
that referenced
this pull request
May 22, 2019
thibaudcolas
approved these changes
May 22, 2019
There was a problem hiding this comment.
Thank you @pahacofome! Reviewed together with @zerolab. BaseMediaChooserPanel is no longer of any use but we decided to keep it with a deprecation note, so people have a chance to upgrade painlessly.
This was referenced May 22, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from wagtail/wagtail#4377 (comment)