Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add release action #8

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

leonheldattoradex
Copy link
Contributor

No description provided.

Signed-off-by: Leonardo Held <leonardo.held@toradex.com>
@leonheldattoradex leonheldattoradex merged commit 1158432 into toradex/any Feb 21, 2024
14 checks passed
@leonheldattoradex leonheldattoradex deleted the ljh/add-release-action branch February 21, 2024 14:32
Copy link
Contributor

@charles2910 charles2910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)


- name: Release
# FIXME: use tag when https://github.com/softprops/action-gh-release/issues/410 is closed
uses: softprops/action-gh-release@4634c16e79c963813287e889244c50009e7f0981
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the issue, it's just a warning about deprecation. Do you think it's worth fixing the hash instead of just leaving the @v1 and wait the upcoming release to fix it.

My concern is that we will probably forget to update it and it'll be fixed until the next time we have to look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants