Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix location of dynamixel launch #42

Closed
wants to merge 1 commit into from
Closed

fix location of dynamixel launch #42

wants to merge 1 commit into from

Conversation

534o
Copy link
Member

@534o 534o commented Jul 2, 2015

see #38

@534o 534o mentioned this pull request Jul 2, 2015
Merged
This was referenced Jul 2, 2015
Merged
Merged
@534o 534o changed the title fixed version of #38 fix location of dynamixel launch Jul 2, 2015
@534o
Copy link
Member Author

534o commented Jul 2, 2015

this will solve travis failure, but I think we should not accept this PR because we have both bringup -> controller and controller -> bringup dependency and that is not a good.
Maybe we had wrong decision at ->
e2dbcd6

@130s
Copy link
Contributor

130s commented Jul 2, 2015

My bad, moving spur_dynamixel.launch back to spur_controller makes sense to me if that sounds good.

@534o 534o mentioned this pull request Jul 2, 2015
Merged
@130s 130s mentioned this pull request Jul 2, 2015
Merged
@130s
Copy link
Contributor

130s commented Jul 2, 2015

Closing due to #46 that reverts the previous wrong commit e2dbcd6.

@130s 130s closed this Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@534o @130s