Issue #2147: avoid copies on non-small writes #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't read the full diff yet, but in #2008 we found that using |
|
I've checked that this PR is immune to #2008. |
bdarnell
reviewed
Nov 6, 2017
tornado/iostream.py
Outdated
| elif size > 0: | ||
| if self._buffers: | ||
| is_large, b = self._buffers[-1] | ||
| is_large = is_large or len(b) >= self._large_buf_threshold |
There was a problem hiding this comment.
is_large is doing a lot of different things here. I think it woudl be more clear if this were
if self._buffers:
is_memview, b = self._buffers[-1]
new_buf = is_memview or len(b) > self._large_buf_threshold
else:
new_buf = True
tornado/iostream.py
Outdated
| def peek(self, size): | ||
| assert size > 0 | ||
| try: | ||
| is_large, b = self._buffers[0] |
tornado/iostream.py
Outdated
| else: | ||
| return memoryview(b)[pos:pos + size] | ||
|
|
||
| def skip(self, size): |
There was a problem hiding this comment.
Maybe call this advance or consume?
|
There was a hang in the latest Travis build on 2.7. I'm not able to reproduce locally. |
This was referenced Nov 8, 2017
|
Thanks! |
|
(I reran the travis build and it passed, so the hang was just a fluke) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance by 35% on the following benchmark: #2147 (comment)
Makes
demos/benchmark/benchmark.pyabout 2% slower.(split from #2166)