test: Close a websocket client that causes occasional test failures #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These failures occur on the build.yml workflow on the emulated arm64 platform: an ill-timed timer firing during test shutdown can result in a message being logged and the test failing for dirty logs.
These will fail when run from forks because the necessary credentials aren't available.
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
May 7, 2023
This gives a warning that is not dependent on GC for the issue in tornadoweb#3257.
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
May 7, 2023
This gives a warning that is not dependent on GC for the issue in tornadoweb#3257.
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
May 7, 2023
This gives a warning that is not dependent on GC for the issue in tornadoweb#3257. This new warning covers all websocket client connections, while the previous GC-dependent warning only affected those with ping_interval set. This unfortunately introduces an effective requirement to close all websocket clients explicitly for those who are strict about warnings.
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
May 8, 2023
This gives a warning that is not dependent on GC for the issue in tornadoweb#3257. This new warning covers all websocket client connections, while the previous GC-dependent warning only affected those with ping_interval set. This unfortunately introduces an effective requirement to close all websocket clients explicitly for those who are strict about warnings.
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
May 8, 2023
This gives a warning that is not dependent on GC for the issue in tornadoweb#3257. This new warning covers all websocket client connections, while the previous GC-dependent warning only affected those with ping_interval set. This unfortunately introduces an effective requirement to close all websocket clients explicitly for those who are strict about warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These failures occur on the build.yml workflow on the emulated arm64
platform: an ill-timed timer firing during test shutdown can result
in a message being logged and the test failing for dirty logs.