Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--fastq_stats: remove option --output from the list of accepted options #572

Closed
frederic-mahe opened this issue Sep 11, 2024 · 1 comment
Assignees

Comments

@frederic-mahe
Copy link
Collaborator

--fastq_stats accepts --option but does not do anything with it. If that option is not there for compatibility with usearch (which I need to check), then I suggest we remove it:

option_output,

@frederic-mahe
Copy link
Collaborator Author

For usearch 5 to 11, test if command --fastq_stats accepts option --output and creates a corresponding file:

cd /tmp/

printf "@s\nA\n+\nI\n" > tmp.fastq

for USEARCH in usearch{5..11} ; do
    rm -rf tmp.output
    ${USEARCH} --fastq_stats tmp.fastq --output tmp.output
    ls -lh tmp.output
done

rm -rf tmp.output tmp.fastq

In summary:

usearch accepts --fastq_stats accepts --output creates output file
5 no no no
6 yes yes no
7 yes yes no
8 yes warning no
9 yes warning no
10 no no no
11 no no no

usearch 8 and 9 output a warning: WARNING: Option -output ignored. Option --output is clearly not intended to be used with command --fastq_stats. I decide to remove --output from the list of valid options for --fastq_stats (commit e4895e4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant