Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename variables to follow conventions #344

Closed
Tracked by #349
josecelano opened this issue Nov 13, 2023 · 1 comment · Fixed by #348
Closed
Tracked by #349

Rename variables to follow conventions #344

josecelano opened this issue Nov 13, 2023 · 1 comment · Fixed by #348

Comments

@josecelano
Copy link
Member

Depends on: torrust/torrust-index#361
josecelano added a commit to josecelano/torrust-index-gui that referenced this issue Nov 15, 2023
@josecelano
refactor: [torrust#344] rename Index env vars to follow changes in th…
ac1b7dc 
…e Index

```
TORRUST_INDEX_BACK_CORS_PERMISSIVE -> TORRUST_INDEX_API_CORS_PERMISSIVE
TORRUST_IDX_BACK_USER_UID          -> USER_ID
```
josecelano added a commit to josecelano/torrust-index-gui that referenced this issue Nov 15, 2023
@josecelano
refactor: [torrust#344] rename env vars
dd1167e 
Repo was renamed from `torrust-index-frontend` to `torrust-index-gui`.

```
TORRUST_IDX_FRON_RUN_AS_USER       -> TORRUST_INDEX_GUI_RUN_AS_USER
TORRUST_IDX_FRON_USER_UID          -> TORRUST_INDEX_GUI_USER_UID
TORRUST_IDX_FRON_API_BASE_URL      -> TORRUST_INDEX_GUI_API_BASE_URL
```

This commit renames anv vars to follow repo renaming. Besides, we are
not using the abbreviation `IDX` for `INDEX` anymore.
josecelano added a commit that referenced this issue Nov 15, 2023
@josecelano
Merge #348: refactor: [#344] rename Index env vars to follow changes …
b335a99 
…in the Index

dd1167e refactor: [#344] rename env vars (Jose Celano)
ac1b7dc refactor: [#344] rename Index env vars to follow changes in the Index (Jose Celano)

Pull request description:

  [Env variables were renamed in the Index](torrust/torrust-index#361).

  ```text
  TORRUST_INDEX_BACK_CORS_PERMISSIVE -> TORRUST_INDEX_API_CORS_PERMISSIVE
  TORRUST_IDX_BACK_USER_UID          -> USER_ID
  ```

  And we also have to rename GUI env vars to follow the repo renaming.

  ```text
  TORRUST_IDX_FRON_RUN_AS_USER       -> TORRUST_INDEX_GUI_RUN_AS_USER
  TORRUST_IDX_FRON_USER_UID          -> TORRUST_INDEX_GUI_USER_UID
  TORRUST_IDX_FRON_API_BASE_URL      -> TORRUST_INDEX_GUI_API_BASE_URL
  ```

  - [X] Rename Index env vars
  - [x] Rename Index GUI env vars

ACKs for top commit:
  josecelano:
    ACK dd1167e

Tree-SHA512: 7e80f972b0f4f961d2df6464f98a42ba3784b2f164aacd271b380d53b59e064bc68be7a792ba8a2b0fa18842228b029390c03bd6b8393f19cc2aba2619f737fd
@josecelano josecelano linked a pull request Nov 15, 2023 that will close this issue
refactor: rename Index env vars to follow changes in the Index #348
Merged
2 tasks
@josecelano
Copy link
Member Author

CLosed via #348

@josecelano josecelano mentioned this issue Nov 15, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rename Index env vars to follow changes in the Index josecelano/torrust-index-gui
1 participant
@josecelano