Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI layout needs some work #428

Open
1 of 2 tasks
mario-nt opened this issue Jan 4, 2024 · 2 comments
Open
1 of 2 tasks

GUI layout needs some work #428

mario-nt opened this issue Jan 4, 2024 · 2 comments
Assignees
Labels
- User - Enjoyable to Use our Software Enhancement / Feature Request Something New UI User Interface UX User Experience
Milestone

Comments

@mario-nt
Copy link
Contributor

mario-nt commented Jan 4, 2024

The size of the elements of the torrents lists page needs to be adjusted, their size is too small when using a high resolution monitor (e.g. 2560x1440p), leaving a lot of empty space in the page.

Also I think the footer should always be rendered at the end of the page, as right now there is a black space below it, although it is only noticeable when using a light theme, it should be changed.

The GUI in 100% zoom in 2560x1440p resolution:

image

The footer does not fill the entire page, it can be seen clearly with light themes:

image

How it should look like :

image

Tasks:

  • Fix footer
  • Fix elements size is too small with high resolutions
@cgbosse cgbosse added this to the v3.0.0 milestone Jan 16, 2024
@josecelano josecelano added Enhancement / Feature Request Something New - User - Enjoyable to Use our Software UX User Experience UI User Interface labels Jan 22, 2024
@mario-nt mario-nt removed their assignment Jan 30, 2024
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 27, 2024
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 27, 2024
hungfnt added a commit to hungfnt/torrust-index-gui that referenced this issue Apr 27, 2024
@hungfnt
Copy link
Contributor

hungfnt commented Apr 27, 2024

The footer does not fill the entire page, it can be seen clearly with light themes:

Do you use light theme with some sort of dark theme extension enabled? I think we should make the GUI compatible with those extensions.

josecelano added a commit that referenced this issue Apr 29, 2024
8aa6c3a fix:[#428] footer fix (ngthhu)

Pull request description:

  I removed the `bg-base-300` class because it was already applied to the `html` tag.

ACKs for top commit:
  josecelano:
    ACK 672fd50

Tree-SHA512: e9b1e80851620117407b385a0ecd4cfeb30f4a491c02a24b6edd06727b20714f205f0742d5ba50182636452b8a9888dc8c25542e13dd9377fb03df9d9e48ae80
@mario-nt
Copy link
Contributor Author

The footer does not fill the entire page, it can be seen clearly with light themes:

Do you use light theme with some sort of dark theme extension enabled? I think we should make the GUI compatible with those extensions.

Hi @ngthhu , sorry for the late response. We are currently using DaisyUI, Tailwind CSS and nuxtjs/color-mode for the themes. The dark mode was the only theme for the GUI for a long time. The light theme mode was implemented a few months ago creating a new light theme and with the help of the nuxtjs/color-mode package.

@cgbosse cgbosse modified the milestones: v3.0.0, v3.1.0 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- User - Enjoyable to Use our Software Enhancement / Feature Request Something New UI User Interface UX User Experience
Projects
Status: Todo
Development

No branches or pull requests

4 participants