Skip to content

Commit

Permalink
Merge #686: fix: [#580] E2E tests failing with MySQL
Browse files Browse the repository at this point in the history
72f4c69 fix: [#580] E2E tests failing with MySQL (Jose Celano)

Pull request description:

  This seems to fix the issue running E2E tests with MySQL on a GitHub runner, but I'm not sure. I've executed the tests twice.

ACKs for top commit:
  josecelano:
    ACK 72f4c69

Tree-SHA512: 3eb97cfd38cd99b58e8dd5204385a56913dfdfb3d38f83d571ba2278c2c6037cdb62f35b9b67000682efec8db4d567744d15c48b1454983828746e05d121baf0
  • Loading branch information
josecelano committed Jul 29, 2024
2 parents 6dd4e19 + 72f4c69 commit 50aa14e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion contrib/dev-tools/container/e2e/mysql/run-e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ docker ps
# Run E2E tests with shared app instance
TORRUST_INDEX_E2E_SHARED=true \
TORRUST_INDEX_CONFIG_TOML_PATH="./share/default/config/index.public.e2e.container.mysql.toml" \
TORRUST_INDEX_E2E_DB_CONNECT_URL="mysql://root:root_secret_password@localhost:3306/torrust_index_e2e_testing" \
TORRUST_INDEX_E2E_DB_CONNECT_URL="mysql://root:root_secret_password@127.0.0.1:3306/torrust_index_e2e_testing" \
cargo test ||
{
./contrib/dev-tools/container/e2e/mysql/e2e-env-down.sh
Expand Down
2 changes: 1 addition & 1 deletion tests/environments/shared.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ impl TestEnv {
impl Default for TestEnv {
fn default() -> Self {
Self {
authority: "localhost:3001".to_string(),
authority: "127.0.0.1:3001".to_string(),
}
}
}

0 comments on commit 50aa14e

Please sign in to comment.