-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration from actix-web
to Axum
#156
Labels
Code Cleanup / Refactoring
Tidying and Making Neat
Comments
Closed
Hi @da2ce7, I have started with the migration. |
This was referenced Jun 8, 2023
Closed
Closed
Closed
josecelano
added
Code Cleanup / Refactoring
Tidying and Making Neat
Easy
Good for Newcomers
and removed
Easy
Good for Newcomers
labels
Jun 8, 2023
This was referenced Jun 9, 2023
Closed
Closed
Done. There are two related issues to implement in the new Axum implementation. |
Merged
josecelano
added a commit
that referenced
this issue
Sep 19, 2023
2cb0ade chore: remove unused dependencies (Jose Celano) 378d19b chore: cargo update (Jose Celano) Pull request description: - Update dependencies: `cargo update` - Removed unused dependencies: `actix-web`, `actix-multipart`, `actix-cors`. The [API was migrated to Auxm](#156), but [the dependency was not removed](#208). Top commit has no ACKs. Tree-SHA512: 4b974d2bcb29c6202b2bc5a96e4115dd1aa1e7b11bf09c64d49eb29363869b9f4e2b7c9f46c32d35f49c09101cb5c542c52185cbbdf459d9de76349d7bbce2fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@da2ce7 @WarmBeer and @josecelano agreed to migrate from actix-web to Axum. We also did it on the tracker:
The main reason in this case is we can have the same dependency in all torrust projects and there was no other reason not to do it. But after making the decision, a new issue was opened on the tracker:
torrust/torrust-tracker#324
It seems Axum does not have a well-defined and tested implementation for client request timeouts. That could lead to denial of service attacks since once a client opens a connection, it's never closed automatically if the client is inactive for a long time.
I think we should postpone this issue for the time being @WarmBeer @da2ce7.
Subtasks
tag
service #187root
enpoints #198about
context #178user
context #183category
context #179settings
context #181tag
context #188torrent
context #182proxy
context #180Related issues
The text was updated successfully, but these errors were encountered: