Add more contrains for usernames #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
josecelano
added
Enhancement / Feature Request
Usernames will only allow the following characters:
- Uppercase and lowercase letters (`A-Z`, `a-z`)
- Digits (`0-9`)
- The simple dash (`-`)
- The underscore (`_`)
Additionally, we'll enforce a maximum length of 20 characters for the usernames.
We exclude emojis, blank spaces, non-valid UTF-8 characters, and non-ASCII characters
```regex
^[A-Za-z0-9-_]{1,20}$
```
Explanation:
- `^` asserts the start of the string.
- `[A-Za-z0-9-]` is a character class that matches uppercase letters (`A-Z`), lowercase letters (`a-z`), digits (`0-9`), and the simple dash (`-`) or underscore (`_`).
- `{1,20}` quantifier makes sure that the preceding character class matches between 1 and 20 times, inclusive, which enforces your maximum length requirement.
- `$` asserts the end of the string.
This regular expression ensures that usernames consist only of the specified characters and do not exceed 20 characters in length. It effectively excludes emojis, blank spaces, non-valid UTF-8 characters, and non-ASCII characters, as they are not included in the specified character set.
The API endpoint `/register` for registration should return a Bad Request when the username does to match this regexp.
josecelano
force-pushed
the
503-validate-username-before-signup
branch
from
3ce33bd
to
553208e
Compare
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
|
ACK 553208e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usernames will only allow the following characters:
A-Z,a-z)0-9)-)_)Additionally, we'll enforce a maximum length of 20 characters for the usernames.
We exclude emojis, blank spaces, non-valid UTF-8 characters, and non-ASCII characters
Explanation:
^asserts the start of the string.[A-Za-z0-9-]is a character class that matches uppercase letters (A-Z), lowercase letters (a-z), digits (0-9), and the simple dash (-) or underscore (_).{1,20}quantifier makes sure that the preceding character class matches between 1 and 20 times, inclusive, which enforces your maximum length requirement.$asserts the end of the string.This regular expression ensures that usernames consist only of the specified characters and do not exceed 20 characters in length. It effectively excludes emojis, blank spaces, non-valid UTF-8 characters, and non-ASCII characters, as they are not included in the specified character set.
The API endpoint
/registerfor registration should return a Bad Request when the username does to match this regexp.