Fix create/drop indexes in every migration #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henadzit
reviewed
Dec 6, 2024
waketzheng
force-pushed
the
fix/create-drop-indexes-in-every-migration
branch
from
c168d24 to
87207f7
Compare
…xes-in-every-migration
henadzit
reviewed
Dec 12, 2024
| return type(self) is type(other) and hash(self) == hash(other) | ||
|
|
||
| setattr(index_cls, "__hash__", _hash) | ||
| setattr(index_cls, "__eq__", _eq) |
There was a problem hiding this comment.
You are setting the lower boundary on the tortoise version in #388. Why not just implement __eq__ and __hash__ in Tortoise and set the corresponding version boundary. You won't have to have this hacky code then.
There was a problem hiding this comment.
@henadzit I check the tortoise version before patch Index and add a TODO mark.
There was a problem hiding this comment.
Hey, can you please let me know your arguments for why you want to have the patching code instead of increasing the version requirements?
7 tasks
henadzit
reviewed
Dec 16, 2024
| return type(self) is type(other) and hash(self) == hash(other) | ||
|
|
||
| setattr(index_cls, "__hash__", _hash) | ||
| setattr(index_cls, "__eq__", _eq) |
There was a problem hiding this comment.
Hey, can you please let me know your arguments for why you want to have the patching code instead of increasing the version requirements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on #311
Will close #258