Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enums not quoted #10

Merged
merged 18 commits into from
Nov 18, 2024
Merged

Conversation

waketzheng
Copy link
Contributor

@waketzheng waketzheng commented May 25, 2024

Fixes #7

Most code copied from kayak/pypika#576
Then add test for datetime.time type, and run poetry update to upgrade dependencies, changed ruff command and config to fix warnings.
Add py.typed and pass mypy check.
Refactor utils and move Exceptions to a new file (exceptions.py)

@waketzheng
Copy link
Contributor Author

@abondar Could you review this?

@waketzheng waketzheng mentioned this pull request Nov 15, 2024
@henadzit
Copy link
Contributor

Hey @waketzheng, thank you for PR!

Can you please provide a code snippet that uses Tortoise and exposes the bug? Maybe, a test case in Tortoise that will show the failing functionality.

It would be helpful if you create a PR to tortoise-orm where your version of pypika-tortoise is used, so we can see that CI passes. You can do it specifying your fork as a source for pypika-tortoise:
pypika-tortoise = { git = "https://github.com/waketzheng/pypika-tortoise.git", branch = "fix-enums-not-quoted" }

@waketzheng
Copy link
Contributor Author

Hey @waketzheng, thank you for PR!

Can you please provide a code snippet that uses Tortoise and exposes the bug? Maybe, a test case in Tortoise that will show the failing functionality.

It would be helpful if you create a PR to tortoise-orm where your version of pypika-tortoise is used, so we can see that CI passes. You can do it specifying your fork as a source for pypika-tortoise: pypika-tortoise = { git = "https://github.com/waketzheng/pypika-tortoise.git", branch = "fix-enums-not-quoted" }

@henadzit done. tortoise/tortoise-orm#1776

@abondar
Copy link
Member

abondar commented Nov 18, 2024

@waketzheng Should I merge it and release?

Or you would like to do it yourself?

@waketzheng
Copy link
Contributor Author

@waketzheng Should I merge it and release?

Or you would like to do it yourself?

Let me do it.

@waketzheng waketzheng merged commit def1617 into tortoise:main Nov 18, 2024
6 checks passed
@waketzheng waketzheng deleted the fix-enums-not-quoted branch November 18, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enums not quoted
3 participants