Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made it possible to pass the "index_type" argument in the Index and PartialIndex constructors #1368

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

DeveloperAnonymous
Copy link

Description

Title pretty much explains it all. This is so we can set the index as unique without the need of super seeding the class

Motivation and Context

It just feels more natural to have it passed in the constructor as it is part of the index behavior to be unique or not, the type should not need to be overridden in another class

How Has This Been Tested?

This has not been tested, but I'm fairly confident in this small change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant