Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix executor todos #1672

Merged
merged 6 commits into from
Aug 1, 2024
Merged

Fix executor todos #1672

merged 6 commits into from
Aug 1, 2024

Conversation

waketzheng
Copy link
Contributor

Description

Fix all TODOs in tortoise/backend/base/executor.py

Motivation and Context

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9741475399

Details

  • 26 of 28 (92.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 89.048%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/base/executor.py 26 28 92.86%
Totals Coverage Status
Change from base Build 9646263030: -0.05%
Covered Lines: 5922
Relevant Lines: 6549

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10154861691

Details

  • 26 of 28 (92.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 89.112%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/base/executor.py 26 28 92.86%
Totals Coverage Status
Change from base Build 10115140001: -0.05%
Covered Lines: 5955
Relevant Lines: 6568

💛 - Coveralls

@abondar abondar merged commit 3b620e4 into tortoise:develop Aug 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants