Skip to content

Commit

Permalink
netfilter: ctnetlink: put back references to master ct and expect obj…
Browse files Browse the repository at this point in the history
…ects

We have to put back the references to the master conntrack and the expectation
that we just created, otherwise we'll leak them.

Fixes: 0ef71ee ("netfilter: ctnetlink: refactor ctnetlink_create_expect")
Reported-by: Tim Wiess <Tim.Wiess@watchguard.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  • Loading branch information
ummakynes committed Jul 10, 2015
1 parent a7d35f9 commit 95dd865
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions net/netfilter/nf_conntrack_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -2995,11 +2995,6 @@ ctnetlink_create_expect(struct net *net, u16 zone,
}

err = nf_ct_expect_related_report(exp, portid, report);
if (err < 0)
goto err_exp;

return 0;
err_exp:
nf_ct_expect_put(exp);
err_ct:
nf_ct_put(ct);
Expand Down

0 comments on commit 95dd865

Please sign in to comment.