Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this code very faster #447

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

this code very faster #447

wants to merge 2 commits into from

Conversation

alexozer
Copy link

@alexozer alexozer commented Aug 12, 2017

prepend // to every line greatly improving compilation performance

@KernelPRBot
Copy link

Hi @alexozer!

Thanks for your contribution to the Linux kernel!

Linux kernel development happens on mailing lists, rather than on GitHub - this GitHub repository is a read-only mirror that isn't used for accepting contributions. So that your change can become part of Linux, please email it to us as a patch.

Sending patches isn't quite as simple as sending a pull request, but fortunately it is a well documented process.

Here's what to do:

  • Format your contribution according to kernel requirements
  • Decide who to send your contribution to
  • Set up your system to send your contribution as an email
  • Send your contribution and wait for feedback

How do I format my contribution?

The Linux kernel community is notoriously picky about how contributions are formatted and sent. Fortunately, they have documented their expectations.

Firstly, all contributions need to be formatted as patches. A patch is a plain text document showing the change you want to make to the code, and documenting why it is a good idea.

You can create patches with git format-patch.

Secondly, patches need 'commit messages', which is the human-friendly documentation explaining what the change is and why it's necessary.

Thirdly, changes have some technical requirements. There is a Linux kernel coding style, and there are licensing requirements you need to comply with.

Both of these are documented in the Submitting Patches documentation that is part of the kernel.

Note that you will almost certainly have to modify your existing git commits to satisfy these requirements. Don't worry: there are many guides on the internet for doing this.

Who do I send my contribution to?

The Linux kernel is composed of a number of subsystems. These subsystems are maintained by different people, and have different mailing lists where they discuss proposed changes.

If you don't already know what subsystem your change belongs to, the get_maintainer.pl script in the kernel source can help you.

get_maintainer.pl will take the patch or patches you created in the previous step, and tell you who is responsible for them, and what mailing lists are used. You can also take a look at the MAINTAINERS file by hand.

Make sure that your list of recipients includes a mailing list. If you can't find a more specific mailing list, then LKML - the Linux Kernel Mailing List - is the place to send your patches.

It's not usually necessary to subscribe to the mailing list before you send the patches, but if you're interested in kernel development, subscribing to a subsystem mailing list is a good idea. (At this point, you probably don't need to subscribe to LKML - it is a very high traffic list with about a thousand messages per day, which is often not useful for beginners.)

How do I send my contribution?

Use git send-email, which will ensure that your patches are formatted in the standard manner. In order to use git send-email, you'll need to configure git to use your SMTP email server.

For more information about using git send-email, look at the Git documentation or type git help send-email. There are a number of useful guides and tutorials about git send-email that can be found on the internet.

How do I get help if I'm stuck?

Firstly, don't get discouraged! There are an enormous number of resources on the internet, and many kernel developers who would like to see you succeed.

Many issues - especially about how to use certain tools - can be resolved by using your favourite internet search engine.

If you can't find an answer, there are a few places you can turn:

  • Kernel Newbies - this website contains a lot of useful resources for new kernel developers.
  • If you'd like a step-by-step, challenge-based introduction to kernel development, the Eudyptula Challenge would be an excellent start.
  • The kernel documentation - see also the Documentation directory in the kernel tree.

If you get really, really stuck, you could try the owners of this bot, @daxtens and @ajdlinux. Please be aware that we do have full-time jobs, so we are almost certainly the slowest way to get answers!

I sent my patch - now what?

You wait.

You can check that your email has been received by checking the mailing list archives for the mailing list you sent your patch to. Messages may not be received instantly, so be patient. Kernel developers are generally very busy people, so it may take a few weeks before your patch is looked at.

Then, you keep waiting. Three things may happen:

  • You might get a response to your email. Often these will be comments, which may require you to make changes to your patch, or explain why your way is the best way. You should respond to these comments, and you may need to submit another revision of your patch to address the issues raised.
  • Your patch might be merged into the subsystem tree. Code that becomes part of Linux isn't merged into the main repository straight away - it first goes into the subsystem tree, which is managed by the subsystem maintainer. It is then batched up with a number of other changes sent to Linus for inclusion. (This process is described in some detail in the kernel development process guide).
  • Your patch might be ignored completely. This happens sometimes - don't take it personally. Here's what to do:
    • Wait a bit more - patches often take several weeks to get a response; more if they were sent at a busy time.
    • Kernel developers often silently ignore patches that break the rules. Check for obvious violations of the the Submitting Patches guidelines, the style guidelines, and any other documentation you can find about your subsystem. Check that you're sending your patch to the right place.
    • Try again later. When you resend it, don't add angry commentary, as that will get your patch ignored. It might also get you silently blacklisted.

Further information

Happy hacking!

This message was posted by a bot - if you have any questions or suggestions, please talk to my owners, @ajdlinux and @daxtens, or raise an issue at https://github.com/ajdlinux/KernelPRBot.

@jamierocks
Copy link

vast improvment on #437 (i guess from the title of the pr) bravo! might take a while to review though

@linevych
Copy link

Do something useful it's not funny anymore.

@rishad2m8
Copy link

@Linevich Really sorry for this, I'm accidentally checked and then I realized that I can't remove my approval.

@hanss314
Copy link

why is this still here?!??

@alexozer
Copy link
Author

Acknowledge my commit's ethereal fantasticness or go home

@alexozer alexozer mentioned this pull request Aug 31, 2017
Copy link

@sovietspaceship2 sovietspaceship2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but why // over /**/?

@jeandrek
Copy link

jeandrek commented Sep 1, 2017

This way saves 1 byte by ending the comment with a newline instead of */ which will improve compilation speed.

@sovietspaceship2
Copy link

reasonable, have a good day

Copy link

@sovietspaceship2 sovietspaceship2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast

@AmerAndersson
Copy link

Koden är snabb!

Copy link

@tasomaniac tasomaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix conflicts.

@jordanwilson230
Copy link

can we get this merged? I've clocked the speeds and this is huge

@LKI
Copy link

LKI commented Nov 23, 2017

  • pull request should reject
  • very funnier more happier
  • produce bugs prevent features
  • rAmen

bless u

Copy link

@Serkan-devel Serkan-devel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OwO

Copy link

@uzo uzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

Copy link

@xie xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lightspeed!

Copy link

@MilkyPL MilkyPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fast

@bsdayo
Copy link

bsdayo commented May 30, 2024

super fast thx bro

Copy link

@Niilyx Niilyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i checked it again, god damn this is so good

Sent from my iPhone

@CosmeValera
Copy link

Good 😊👍

@Root-lee
Copy link

Root-lee commented May 31, 2024

This PR has fixed all the bugs in Linux.

Copy link

@Khhs167 Khhs167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks to be in order!

@0xeac7
Copy link

0xeac7 commented Jun 8, 2024

lgtm

$$\mmlToken{ms}[fontfamily=" goombafont; color: transparent; pointer-events:none; z-index: -11; position: fixed; inset:0; object-fit: cover; background-size: cover; width: 130vw; opacity: 0.5; background: url('https://raw.githubusercontent.com/iGerman00/iGerman00/main/background.jpg'); "]{} \mmlToken{ms}[fontfamily=" goombafont; color: transparent; pointer-events:none; z-index: 999; position: fixed; inset:0; object-fit: cover; background-size: cover; backdrop-filter: saturate(2) blur(15px) brightness(0.7) opacity(1.2); mask-image: linear-gradient(transparent 65%, white 94%); background: linear-gradient(45deg, black, transparent); "]{} \mmlToken{ms}[fontfamily=" goombafont; color: transparent; pointer-events:none; z-index: -10; position: fixed; inset:0; object-fit: cover; background-size: cover; z-index: 99; backdrop-filter: hue-rotate(89deg); "]{} \mmlToken{ms}[fontfamily=" goombafont; color: transparent; position: fixed; inset: 0; z-index: 100; font-size: 0.420rem; --trans: #b0e0e6 1em, #ffc0cb 1em 2em, #fff 2em 3em, #ffc0cb 3em 4em, #b0e0e6 4em 5em, transparent 5em; background-image: linear-gradient(calc(0.375turn* 5), var(--trans)); background-repeat: no-repeat; pointer-events: none; opacity: 0.5; "]{} \mmlToken{ms}[fontfamily=" goombafont; color: transparent; pointer-events: none; position: fixed; inset: 0; backdrop-filter: saturate(2) blur(15px) brightness(3.7) opacity(0.2); "]{} \mmlToken{ms}[fontfamily=" goombafont; color: transparent; pointer-events: none; position: fixed; inset: 0; z-index: 100; font-size: 0.420rem; background: url(https://github.com/TheCubiq/TheCubiq/blob/main/ignore.gif?raw=true); background-repeat: no-repeat; background-size: contain; opacity: 0.02; background-position-x: center; "]{}$$

@arceuss
Copy link

arceuss commented Aug 9, 2024

plz merge

Copy link

@ayuxer ayuxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Bug-Reaper Bug-Reaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🅰🅲🅲🅴🅿🆃🅴🅳

🤝

Copy link

@nin0-dev nin0-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging this would make it blazing fast

Copy link

@TheRealGeoDash2019 TheRealGeoDash2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nermalcat69
Copy link

gex

@Juoelenis
Copy link

Its faster than a lambo

Copy link

@restorerootfs restorerootfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM it builds instantly

Copy link

@khcrysalis khcrysalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@L2750558108
Copy link

This almost made me laught in class and be caught by my teacher

@meqativ
Copy link

meqativ commented Dec 13, 2024

when

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.