Linux 6.0 #695

Jprimero15 · 2019-06-30T13:12:37Z

Fixes lot of bugs

- Fixes lot of bugs

KernelPRBot · 2019-06-30T13:15:14Z

Thanks for your contribution to the Linux kernel!

Linux kernel development happens on mailing lists, rather than on GitHub - this GitHub repository is a read-only mirror that isn't used for accepting contributions. So that your change can become part of Linux, please email it to us as a patch.

Sending patches isn't quite as simple as sending a pull request, but fortunately it is a well documented process.

Here's what to do:

Format your contribution according to kernel requirements
Decide who to send your contribution to
Set up your system to send your contribution as an email
Send your contribution and wait for feedback

How do I format my contribution?

The Linux kernel community is notoriously picky about how contributions are formatted and sent. Fortunately, they have documented their expectations.

Firstly, all contributions need to be formatted as patches. A patch is a plain text document showing the change you want to make to the code, and documenting why it is a good idea.

You can create patches with git format-patch.

Secondly, patches need 'commit messages', which is the human-friendly documentation explaining what the change is and why it's necessary.

Thirdly, changes have some technical requirements. There is a Linux kernel coding style, and there are licensing requirements you need to comply with.

Both of these are documented in the Submitting Patches documentation that is part of the kernel.

Note that you will almost certainly have to modify your existing git commits to satisfy these requirements. Don't worry: there are many guides on the internet for doing this.

Who do I send my contribution to?

The Linux kernel is composed of a number of subsystems. These subsystems are maintained by different people, and have different mailing lists where they discuss proposed changes.

If you don't already know what subsystem your change belongs to, the get_maintainer.pl script in the kernel source can help you.

get_maintainer.pl will take the patch or patches you created in the previous step, and tell you who is responsible for them, and what mailing lists are used. You can also take a look at the MAINTAINERS file by hand.

Make sure that your list of recipients includes a mailing list. If you can't find a more specific mailing list, then LKML - the Linux Kernel Mailing List - is the place to send your patches.

It's not usually necessary to subscribe to the mailing list before you send the patches, but if you're interested in kernel development, subscribing to a subsystem mailing list is a good idea. (At this point, you probably don't need to subscribe to LKML - it is a very high traffic list with about a thousand messages per day, which is often not useful for beginners.)

How do I send my contribution?

Use git send-email, which will ensure that your patches are formatted in the standard manner. In order to use git send-email, you'll need to configure git to use your SMTP email server.

For more information about using git send-email, look at the Git documentation or type git help send-email. There are a number of useful guides and tutorials about git send-email that can be found on the internet.

How do I get help if I'm stuck?

Firstly, don't get discouraged! There are an enormous number of resources on the internet, and many kernel developers who would like to see you succeed.

Many issues - especially about how to use certain tools - can be resolved by using your favourite internet search engine.

If you can't find an answer, there are a few places you can turn:

Kernel Newbies - this website contains a lot of useful resources for new kernel developers.
The kernel documentation - see also the Documentation directory in the kernel tree.

If you get really, really stuck, you could try the owners of this bot, @daxtens and @ajdlinux. Please be aware that we do have full-time jobs, so we are almost certainly the slowest way to get answers!

I sent my patch - now what?

You wait.

You can check that your email has been received by checking the mailing list archives for the mailing list you sent your patch to. Messages may not be received instantly, so be patient. Kernel developers are generally very busy people, so it may take a few weeks before your patch is looked at.

Then, you keep waiting. Three things may happen:

You might get a response to your email. Often these will be comments, which may require you to make changes to your patch, or explain why your way is the best way. You should respond to these comments, and you may need to submit another revision of your patch to address the issues raised.
Your patch might be merged into the subsystem tree. Code that becomes part of Linux isn't merged into the main repository straight away - it first goes into the subsystem tree, which is managed by the subsystem maintainer. It is then batched up with a number of other changes sent to Linus for inclusion. (This process is described in some detail in the kernel development process guide).
Your patch might be ignored completely. This happens sometimes - don't take it personally. Here's what to do:
- Wait a bit more - patches often take several weeks to get a response; more if they were sent at a busy time.
- Kernel developers often silently ignore patches that break the rules. Check for obvious violations of the Submitting Patches guidelines, the style guidelines, and any other documentation you can find about your subsystem. Check that you're sending your patch to the right place.
- Try again later. When you resend it, don't add angry commentary, as that will get your patch ignored. It might also get you silently blacklisted.

Further information

Working with the kernel development community - the official documentation for new kernel contributors

Happy hacking!

This message was posted by a bot - if you have any questions or suggestions, please talk to my owners, @ajdlinux and @daxtens, or raise an issue at https://github.com/ajdlinux/KernelPRBot.

TwistedPrime · 2019-07-01T13:16:28Z

Amazing work!

Jprimero15 · 2019-07-02T10:50:59Z

Thanks... I spent many days and nights to finish this patch.

ya7on

Good work! 👍

Jprimero15 · 2019-07-03T04:39:19Z

Those who reacted " 👎 " surely didn't know anything about linux.

ruidazeng

I don't understand the "bugs" you claimed to fix...all you have changed are the values that VERSION and PATCHLEVEL refers to.

sytranvn

Brilliant! 👍

benclarkk

wait so i can just approve these?

i approve

MattL0 · 2019-07-08T01:22:30Z

I compiled this, and was able to remove the ram of my system. This is awesome

valerierx · 2019-07-10T12:33:56Z

Yeah, it's big brain time

ghost

The name does not include any capitalization, please correct this.

NotNite

cleaned up some really complex code there man

PF94 · 2019-07-13T19:54:20Z

I compiled this, and was able to remove the ram of my system. This is awesome

was meant to be sarcastic?

By the way Linux 6.0's full name/code name is going to be called "Catdog"?

PF94

If this is supposed to be a new version of the Linux kernel, shouldn't it have more improvements than renaming it to "cat dog"?

Even then 5.2 just came out 6 days ago.

ghost · 2019-07-14T01:00:16Z

If this is supposed to be a new version of the Linux kernel, shouldn't it have more improvements than renaming it to "cat dog"?

Even then 5.2 just came out 6 days ago.

I'm believe this whole commit was intended as a joke or something. At least, I certainly hope so.

PF94 · 2019-07-15T13:38:18Z

I'm believe this whole commit was intended as a joke or something. At least, I certainly hope so.

What kind of GitHub Pro user attempts to make a edit on Linux, but just changes the version string to CatDog?

ghost · 2019-07-15T18:42:36Z

I'm believe this whole commit was intended as a joke or something. At least, I certainly hope so.

What kind of GitHub Pro user attempts to make a edit on Linux, but just changes the version string to CatDog?

The Jprimero15 type.

JamesTheHacker · 2019-07-16T19:41:28Z

These constant jokes on here are getting silly now.

PF94 · 2019-07-22T21:55:51Z

Linus should just close this :P

SamHannat

this is possibly the best PR I've ever seen

gnerdalot · 2019-07-30T05:16:27Z

Cats and dogs living together...mass hysteria!

rkhater · 2019-08-03T13:26:35Z

This is brilliant

amenpunk · 2019-08-07T21:58:18Z

WOW 👍

alexis-belmonte · 2019-08-11T18:14:28Z

Brilliant work.

Ntemis · 2019-08-14T20:59:22Z

Please fix the conflicts @Jprimero15 This change needs to be merged ASAP!
Tested and kernel boots fine despite the shitload of changes you are the man!
Can we have an android bootable kernel after this gets in please?

WillNilges

Cool and good and also excellent. 8/8

fgRuslan · 2019-09-13T19:06:59Z

Wow, this is the best and most useful patch ever!

Tricktionary

LGTM

betseg

i approve

sech1p · 2020-01-22T18:21:26Z

Great job! I wouldn't be able to write such a powerful patch myself, kudos for you my friend, respect.

PD#150097: driver defect clean up: torvalds#35 torvalds#39 torvalds#54 torvalds#55 torvalds#83 torvalds#94 torvalds#96 torvalds#102 torvalds#649 torvalds#690 torvalds#695 Change-Id: I1b9a9384100f4e39da246c5242de8e506671454d Signed-off-by: Evoke Zhang <evoke.zhang@amlogic.com>

ANBZ: torvalds#695 commit 9bf3d20 upstream. The block number in the quota tree on disk should be smaller than the v2_disk_dqinfo.dqi_blocks. If the quota file was corrupted, we may be allocating an 'allocated' block and that would lead to a loop in a tree, which will probably trigger oops later. This patch adds a check for the block number in the quota tree to prevent such potential issue. Link: https://lore.kernel.org/r/20211008093821.1001186-2-yi.zhang@huawei.com Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Cc: stable@kernel.org Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Fixes: CVE-2021-45868 Signed-off-by: Hongnan Li <hongnan.li@linux.alibaba.com> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>

shflte · 2024-12-19T08:23:45Z

LGTM!

Linux 6.0

fc1659e

- Fixes lot of bugs

ya7on approved these changes Jul 2, 2019

View reviewed changes

ruidazeng suggested changes Jul 3, 2019

View reviewed changes

sytranvn approved these changes Jul 4, 2019

View reviewed changes

benclarkk approved these changes Jul 6, 2019

View reviewed changes

ghost suggested changes Jul 11, 2019

View reviewed changes

NotNite approved these changes Jul 11, 2019

View reviewed changes

noot approved these changes Jul 12, 2019

View reviewed changes

PF94 suggested changes Jul 13, 2019

View reviewed changes

SamHannat approved these changes Jul 25, 2019

View reviewed changes

salif approved these changes Aug 14, 2019

View reviewed changes

WillNilges approved these changes Aug 15, 2019

View reviewed changes

vietha0996-framgia approved these changes Aug 21, 2019

View reviewed changes

gtsop approved these changes Sep 4, 2019

View reviewed changes

fgRuslan approved these changes Sep 15, 2019

View reviewed changes

Tricktionary approved these changes Sep 19, 2019

View reviewed changes

Sanjit1 approved these changes Oct 8, 2019

View reviewed changes

aUniqueUser approved these changes Oct 22, 2019

View reviewed changes

NotNite approved these changes Nov 10, 2019

View reviewed changes

betseg approved these changes Nov 10, 2019

View reviewed changes

Exploder98 approved these changes Dec 6, 2019

View reviewed changes

2clear approved these changes Jan 17, 2020

View reviewed changes

NexusSfan approved these changes Jun 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linux 6.0 #695

Linux 6.0 #695

Jprimero15 commented Jun 30, 2019

KernelPRBot commented Jun 30, 2019

TwistedPrime commented Jul 1, 2019

Jprimero15 commented Jul 2, 2019

ya7on left a comment

Jprimero15 commented Jul 3, 2019

ruidazeng left a comment

sytranvn left a comment •

edited

Loading

benclarkk left a comment

MattL0 commented Jul 8, 2019

valerierx commented Jul 10, 2019

ghost left a comment

NotNite left a comment

PF94 commented Jul 13, 2019 •

edited

Loading

PF94 left a comment •

edited

Loading

ghost commented Jul 14, 2019 •

edited by ghost

Loading

PF94 commented Jul 15, 2019

ghost commented Jul 15, 2019

JamesTheHacker commented Jul 16, 2019

PF94 commented Jul 22, 2019

SamHannat left a comment

gnerdalot commented Jul 30, 2019

rkhater commented Aug 3, 2019

amenpunk commented Aug 7, 2019

alexis-belmonte commented Aug 11, 2019

Ntemis commented Aug 14, 2019

WillNilges left a comment

fgRuslan commented Sep 13, 2019

Tricktionary left a comment

betseg left a comment

sech1p commented Jan 22, 2020

shflte commented Dec 19, 2024

Linux 6.0 #695

Are you sure you want to change the base?

Linux 6.0 #695

Conversation

Jprimero15 commented Jun 30, 2019

KernelPRBot commented Jun 30, 2019

How do I format my contribution?

Who do I send my contribution to?

How do I send my contribution?

How do I get help if I'm stuck?

I sent my patch - now what?

Further information

TwistedPrime commented Jul 1, 2019

Jprimero15 commented Jul 2, 2019

ya7on left a comment

Choose a reason for hiding this comment

Jprimero15 commented Jul 3, 2019

ruidazeng left a comment

Choose a reason for hiding this comment

sytranvn left a comment • edited Loading

Choose a reason for hiding this comment

benclarkk left a comment

Choose a reason for hiding this comment

MattL0 commented Jul 8, 2019

valerierx commented Jul 10, 2019

ghost left a comment

Choose a reason for hiding this comment

NotNite left a comment

Choose a reason for hiding this comment

PF94 commented Jul 13, 2019 • edited Loading

PF94 left a comment • edited Loading

Choose a reason for hiding this comment

ghost commented Jul 14, 2019 • edited by ghost Loading

PF94 commented Jul 15, 2019

ghost commented Jul 15, 2019

JamesTheHacker commented Jul 16, 2019

PF94 commented Jul 22, 2019

SamHannat left a comment

Choose a reason for hiding this comment

gnerdalot commented Jul 30, 2019

rkhater commented Aug 3, 2019

amenpunk commented Aug 7, 2019

alexis-belmonte commented Aug 11, 2019

Ntemis commented Aug 14, 2019

WillNilges left a comment

Choose a reason for hiding this comment

fgRuslan commented Sep 13, 2019

Tricktionary left a comment

Choose a reason for hiding this comment

betseg left a comment

Choose a reason for hiding this comment

sech1p commented Jan 22, 2020

shflte commented Dec 19, 2024

sytranvn left a comment •

edited

Loading

PF94 commented Jul 13, 2019 •

edited

Loading

PF94 left a comment •

edited

Loading

ghost commented Jul 14, 2019 •

edited by ghost

Loading