Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo mn throws some warns on first build #285

Closed
jamesmunns opened this issue Sep 18, 2023 · 3 comments · Fixed by #286
Closed

cargo mn throws some warns on first build #285

jamesmunns opened this issue Sep 18, 2023 · 3 comments · Fixed by #286
Assignees
@spookyvision

Comments

@jamesmunns
Copy link
Contributor

Tried running cargo mn (with no args) today, and it printed some warnings we might want to address.

$ cargo mn
warning: skipping duplicate package `run-wasm` found at `/Users/james/.cargo/git/checkouts/embedded-graphics-web-simulator-ef34bb7f9f200182/0f07b1e/examples/animated/run-wasm`
  Downloaded cargo-util v0.2.5
...
    Finished release [optimized + debuginfo] target(s) in 1m 25s
     Running `target/release/manganese`
warning: running `mn` without the 'install-deps' feature falls back to just doing nothing!

justfile for MnemOS

Then when running melpomene:

$ cargo mn melpomene
warning: skipping duplicate package `run-wasm` found at `/Users/james/.cargo/git/checkouts/embedded-graphics-web-simulator-ef34bb7f9f200182/0f07b1e/examples/animated/run-wasm`
    Finished release [optimized + debuginfo] target(s) in 0.31s
     Running `target/release/manganese melpomene`
warning: running `mn` without the 'install-deps' feature falls back to just doing nothing!
cargo run --profile release --bin melpomene -- 
warning: skipping duplicate package `run-wasm` found at `/Users/james/.cargo/git/checkouts/embedded-graphics-web-simulator-ef34bb7f9f200182/0f07b1e/examples/animated/run-wasm`
@hawkw
Copy link
Contributor

hawkw commented Sep 18, 2023

The "running mn without the 'install-deps' feature ..." warning was added by me on purpose because i wanted to make it clear that mn wouldn't actually install stuff without that feature. but, the cargo mn alias is supposed to pass that feature, so it seems like that's a bug on my part. Will fix.

The "warning: skipping duplicate package run-wasm ..." warnings show up regardless of whether or not you use mn; i get them when doing a normal cargo build as well. I assume this is due to Pomelo enabling a wasm feature in embedded-graphics, but i don't totally get what's going on there...

hawkw added a commit that referenced this issue Sep 18, 2023
@hawkw
fix(mn): use correct "_any-deps" feature name
98e9855 
Manganese uses a "private" feature flag called "_any-deps" to determine
whether any bindep dependency feature flag is enabled. Unfortunately,
some parts of the code mistakenly use the name "_any_deps" (with a
second "_" instead of a "-") to refer to this feature, which is
incorrect. This results in Manganese always emitting a warning that no
deps were installed, even when this is not actually the case.
Surprisingly, Rust doesn't warn you when you reference a feature flag
that doesn't actually exist, which means we never caught this issue in
development.

This branch fixes that by using the correct name for the feature flag
everywhere.

Fixes #285
@hawkw hawkw mentioned this issue Sep 18, 2023
Merged
hawkw added a commit that referenced this issue Sep 18, 2023
@hawkw
fix(mn): use correct "_any-deps" feature name (#286)
ba81b09 
Manganese uses a "private" feature flag called "_any-deps" to determine
whether any bindep dependency feature flag is enabled. Unfortunately,
some parts of the code mistakenly use the name "_any_deps" (with a
second "_" instead of a "-") to refer to this feature, which is
incorrect. This results in Manganese always emitting a warning that no
deps were installed, even when this is not actually the case.
Surprisingly, Rust doesn't warn you when you reference a feature flag
that doesn't actually exist, which means we never caught this issue in
development.

This branch fixes that by using the correct name for the feature flag
everywhere.

Fixes #285
@jamesmunns jamesmunns assigned spookyvision and unassigned hawkw Sep 19, 2023
@jamesmunns jamesmunns reopened this Sep 19, 2023
@jamesmunns
Copy link
Contributor Author

Reopening to track the second error, and tagging @spookyvision

@spookyvision
Copy link
Contributor

the run-wasm part is now fixed

spookyvision pushed a commit that referenced this issue Sep 20, 2023
fix #285 by updating pomelo e-g-web-sim dependency
1858d00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spookyvision spookyvision

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mn): use correct "_any-deps" feature name tosc-rs/mnemos
3 participants
@spookyvision @jamesmunns @hawkw